Bot proposal: values cleanup for roof:shape

General talk
1

there are some values that are clear typos/duplicates/synonyms of other ones

I want to propose one more bot edit cleaning some of them.

this edit is based on Mechanical edit candidate: roof:shape typos - though I skipped some where I was not fully sure and ones that were fixed since then

roof:shape = piramidal → roof:shape = pyramidal
roof:shape = gable → roof:shape = gabled
roof:shape = Gable → roof:shape = gabled
roof:shape = Flat → roof:shape = flat
roof:shape = hyped → roof:shape = hipped
roof:shape = conical → roof:shape = cone
roof:shape = half_hipped → roof:shape = half-hipped
roof:shape = butterfly_roof → roof:shape = butterfly
roof:shape = butteryfly → roof:shape = butterfly
roof:shape = saw-tooth → roof:shape = sawtooth
roof:shape = sawt → roof:shape = sawtooth
roof:shape = saw_tooth → roof:shape = sawtooth
roof:shape = roundm → roof:shape = round
roof:shape = manshard → roof:shape = mansard
roof:shape = masnsard → roof:shape = mansard
roof:shape = grambel → roof:shape = gambrel
roof:shape = gimbrel → roof:shape = gambrel
roof:shape = gaambrel → roof:shape = gambrel
roof:shape = gambrell → roof:shape = gambrel
roof:shape = hypped → roof:shape = hipped
roof:shape = hippped → roof:shape = hipped
roof:shape = HIPPED → roof:shape = hipped
roof:shape = hippedw → roof:shape = hipped
roof:shape = hipeed → roof:shape = hipped
roof:shape = falt → roof:shape = flat
roof:shape = flate → roof:shape = flat
roof:shape = fla → roof:shape = flat
roof:shape = fkat → roof:shape = flat
roof:shape = flay → roof:shape = flat
roof:shape = Fat → roof:shape = flat
roof:shape = skilion → roof:shape = skillion
roof:shape = skillon → roof:shape = skillion
roof:shape = sjkillion → roof:shape = skillion
roof:shape = skiilion → roof:shape = skillion
roof:shape = Skillion → roof:shape = skillion
roof:shape = skilllion → roof:shape = skillion
roof:shape = skiliton → roof:shape = skillion
roof:shape = skiloon → roof:shape = skillion
roof:shape = side-hipped → roof:shape = side_hipped
roof:shape = ipped-and-gabled → roof:shape = hipped-and-gabled
roof:shape = hipped_and_gabled → roof:shape = hipped-and-gabled
roof:shape = pyramidial → roof:shape = pyramidal
roof:shape = piramyd → roof:shape = pyramidal
roof:shape = pyramide → roof:shape = pyramidal
roof:shape = pyramidical → roof:shape = pyramidal
roof:shape = ppyramidal → roof:shape = pyramidal
roof:shape = pyrimidal → roof:shape = pyramidal
roof:shape = pyramical → roof:shape = pyramidal
roof:shape = pyramdial → roof:shape = pyramidal
roof:shape = pyamidal → roof:shape = pyramidal
roof:shape = pyramedial → roof:shape = pyramidal
roof:shape = =pyramidical → roof:shape = pyramidal
roof:shape = Pyramidal → roof:shape = pyramidal
roof:shape = pyramidalw → roof:shape = pyramidal
roof:shape = pyramdal → roof:shape = pyramidal
roof:shape = pyrmaidal → roof:shape = pyramidal
roof:shape = piramydal → roof:shape = pyramidal
roof:shape = gabed → roof:shape = gabled
roof:shape = gabeled → roof:shape = gabled
roof:shape = gabledｍ → roof:shape = gabled
roof:shape = GABLED → roof:shape = gabled
roof:shape = gabbled → roof:shape = gabled
roof:shape = gabe → roof:shape = gabled
roof:shape = glabbed → roof:shape = gabled
roof:shape = gablet → roof:shape = gabled
roof:shape = gables → roof:shape = gabled
roof:shape = garbed → roof:shape = gabled
roof:shape = garbled → roof:shape = gabled
roof:shape = gabeld → roof:shape = gabled
roof:shape = glabed → roof:shape = gabled
roof:shape = gabledr → roof:shape = gabled
roof:shape = gabledｒ → roof:shape = gabled
roof:shape = gabledh → roof:shape = gabled
roof:shape = gabletd → roof:shape = gabled
roof:shape = grablet → roof:shape = gabled
roof:shape = ggabled → roof:shape = gabled
roof:shape = gabbed → roof:shape = gabled
roof:shape = gabledm → roof:shape = gabled
roof:shape = Gabled → roof:shape = gabled
roof:shape = gabledwW → roof:shape = gabled
roof:shape = gabked → roof:shape = gabled
roof:shape = gableled → roof:shape = gabled
roof:shape = gableds → roof:shape = gabled
roof:shape = galbled → roof:shape = gabled
roof:shape = gabledy< → roof:shape = gabled
roof:shape = gabled¨ → roof:shape = gabled
roof:shape = gabledb → roof:shape = gabled
roof:shape = gabled_ → roof:shape = gabled
roof:shape = gabled. → roof:shape = gabled
roof:shape = gabledv → roof:shape = gabled
roof:shape = gabledx → roof:shape = gabled
roof:shape = gapled → roof:shape = gabled
roof:shape = `gabled → roof:shape = gabled
roof:shape = gabledrrr → roof:shape = gabled
roof:shape = Gabel → roof:shape = gabled
roof:shape = gab → roof:shape = gabled
roof:shape = conical → roof:shape = cone

Cleaning them up, for clear cases, makes map data more usable, less confusing for newbies and software alike.
At quite low cost of editing objects.
Yes, bot edit WILL cause objects to be edited. Nevertheless, as result
map data quality will improve.

Please comment if any of proposed replacements are dubious and should not be replaced with an automated edit.
In such case please, let me know which values are problematic and why.

If someone wants to review but needs more than 2 weeks - please write and I can wait for longer.

Please also comment (or +1) if you checked values proposed to be edited and you agree with the edit!

This bot edit would be rerun from time to time, from
Changesets by Mateusz Konieczny - bot account | OpenStreetMap bot account
.

I have quite decent experience with bot edits, see
https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account#Active_tasks

If anyone wants I can help them to find affected objects or present listing of
edits which added this tags or list people who added this values onto currently
tagged osm objects.

Tried to use them as detectors of bogus data, neither were really useful for this purpose.
We have many better ways to find OSM data requiring human review.

If anyone is looking for more cases where human review is needed - I would be glad to list them
(let me know if you are interested in specific area or specific type of issues - maybe only
shop-related? maybe only ones that require survey? maybe only ones fixable remotely?)

But there is no point in manual drudgery here, with values clearly
replaceable by better matches.

Also, I have a massive queue (in thousands and tens of
thousands) of automatically detectable issues which are not reported by
mainstream validators, require fixes and fix requires review or
complete manual cleanup. And where such manual cleanup adds value,
unlike entries from tags listed above.

This edit is documented at Mechanical Edits/Mateusz Konieczny - bot account/fixing malformed roof:shape tags - OpenStreetMap Wiki

there are also many low-use values with one or two or three extra bogus characters, for example
roof:shape = pyramidal22 → roof:shape = pyramidal

would be also OK to migrate them without listing them
for review here and just add them to replace list later?
And other similar obvious typos appearing or found in future?

Only low use obvious mistakes would be changed without submitting them for review.
If anyone at all will protest and I will not do this and post
for review, like list here, once sufficiently many values are found.

44 Likes
2

I’d also add roof:shape=skilled as a potential typo, considering it’s pretty close to roof:shape=skillion (and both uses are apparently part of roofs onto buildings which often are slanted) and an easy mistake to make (if one which is surprisingly quite rare).
Likewise, roof:shape=slanted which sounds very much like a synonym to roof:shape=skillion.

1 Like
3

Looks likely.

For now I added to add two likely roof shape mistakes · 2cf0482af9 - matkoniecz/dubious_tags - Codeberg.org - I will ask some of people who used it.

I will not add it to this edit as it would invalidate already expressed support. But if it turns out to be a common mistake happening in way as expected, it will likely appear in future one.

3 Likes
4

I believe this set of edits to be a positive proposal.

1 Like
5

Great proposal and sound methodology. I approve

6

Fantastic bot edit.

I was actually going to suggest something similar, and when I logged into the forums, there you go already posting it! Great minds think alike! :slight_smile:

Here’s a few more kinds I caught while scanning TagInfo:

Underscores / Hyphens

  • hipped_and_gabled → hipped-and-gabled
    • 3 hits
  • halfe_hipped → half-hipped
    • 21 hits
      • Looks like this was all accidentally in 1 location in Germany.
    • Extra ‘e’ in there too.

Extra hyphen or underscore in middle:

  • saw-tooth → sawtooth
    • 5 hits
  • saw_tooth → sawtooth
    • 1 hit

Typos

“hyped” instead of “hipped”:

  • hyped → hipped
    • 565 hits
  • half_hyped → half-hipped
    • 1 hit
    • Underscore in there too.
  • halve_hyped → half-hipped
    • 1 hit
    • Underscore in there too.

“sawtooth”:

  • sawtoth → sawtooth
    • 13 hits

Double ‘g’:

  • ggabled → gabled
    • 1 hit

1 Extra/Missing Letter

“1 extra letter”:

  • half-hippedl → half-hipped
    • 1 hit
  • side_hippedm → side_hipped
    • 1 hit
  • sawtooth3 → sawtooth
    • 1 hit

“1 missing letter”:

  • half-hippe → half-hipped
    • 4 hits

Here was one accidental copy/paste category I ran across too:

  • roof:shape=gabledroof:orientation=across

So perhaps those kinds can be “split into 2”:

  • → roof:shape=gabled
  • → roof:orientation=across

Similar with these accidents too:

  • roof:shape=gabled
  • gabledroof:shape=gabled

Looks like they accidentally put roof:shape inside of the roof:shape!

I wonder how pervasive that issue is in many of the other tags…

1 Like
7

I’d be careful with ‘slanted’ as that could be ‘sloped’ too. Where the turn over point is from sloped to skilliion I know not, just when I see skillion, it’s skillion, say 20-30 degrees plus, my favorite the windmill version.

One description of skillion throws a spanner though into the ‘sloped’ view…

" A roof is considered a “skillion roof” (also known as a shed roof or mono-pitched roof) if it features a single, sloping surface extending from one side of the building to the other, unlike traditional roofs with two or more sloping sides meeting at a peak.

Countless here are sloped to force runoff of rain/meltwater to one side. and then it seems that even 5 degrees is considered skillion.

" Skillion Roofs The benefit of a skillion roof is that they provide good water drainage and run off, particularly when they are designed at an ideal pitch between 5-12.5 degrees. Roof pitches on a skillion roof below 5 degrees limits the material types available due to poor drainage."

Reflexion

1 Like
8

added ones until that line to add some likely fitting replacements · ea36497a5c - matkoniecz/OpenStreetMap_cleanup_scripts - Codeberg.org

they may appear in a future bot edit (that will get own proposal)

remaining are a bit more trickier to handle, for now I am not planning to setup bot infrastructure needed to handle them unless some have many many entries

Is roof:shape=sloped documented anywhere? I do not see it at Key:roof:shape - OpenStreetMap Wiki or having own page

9

The most succinct description of ‘skillion’ is ‘steep angle single plane roof’. The ‘slanted’ translating to skillion would be abhorrent without survey.

And here my fav, from the 4D modelling wiki

image
image162×562 20.4 KB

https://wiki.openstreetmap.org/wiki/OSM-4D/Roof_table

10

not planning to do so, neither in this bot edit nor other

but if sloped value makes sense it really should be documented

EDIT: note that “if value makes sense” is not the same as “if anyone at all thinks that value makes sense”, see post below

11

I don’t think it makes sense. And if someone thinks it does, I would hope for a consensus-building discussion before any new values are documented.

In any case, that question is indeed unrelated to the bot edit. Thumbs up on the proposed changes. :slight_smile:

3 Likes