If you want to restore an element to one of its previous versions, you can also use:
element.pl modify w1234567 --to-version 12
Writes to your latest changeset by default.
1 Like
Edit: The results below are incomplete. I’m trying to find out why.
There seem to a few dozens of elements that were deleted by the vandals and not restored yet:
Deleted nodes (30 elements):
8301273666, 10790642186, 4031900556, 4031900557, 553058295, 10238272212, 2698056342
4031900567, 4031900568, 4031900570, 4031900571, 11264955995, 11264955997, 10790499103
10790499104, 2698056354, 9077732325, 8487114342, 9077732326, 9077732327, 2698056301
11115674801, 10809083378, 10809083380, 6437900725, 4031900533, 6437900727, 6593146296
6593146297, 6593146299
Deleted ways (89 elements):
1160484608, 265465602, 923124738, 289639438, 289639440, 396031768, 1172669976, 1113376793
1113376794, 1217360156, 816307492, 30779180, 1217360179, 28987956, 1217360180, 1217360181
816307763, 1217360184, 46338105, 1217360186, 365919030, 413477433, 41802045, 1217360192
1133450306, 1133450307, 260326724, 294759749, 1217360196, 1217360199, 1217360200, 374722882
825126746, 43141211, 684776795, 378654560, 393379427, 265465596, 28988261, 30854758, 874214500
143981932, 505904750, 43705456, 143981936, 142816370, 1159050611, 923128692, 43141498, 143981948
26422912, 266451095, 183005603, 631064995, 30879402, 912453293, 1056690094, 183005615, 183005616
1214465716, 1214465717, 1214465718, 926403517, 532023747, 492978628, 1217360328, 1217360329
1106600138, 1106600139, 1217360331, 1106600141, 1217360330, 1217360332, 1217360333, 1217360334
1217360335, 362673883, 1037171934, 1037171935, 368881124, 408943847, 1185335537, 1181227506
1181227507, 1037169395, 898314229, 893168374, 884890364, 973313789
Deleted relations (0 elements):
I feel that these are not the appropriate time and conditions for me to start using the revert scripts.
P.S.,
The lists are for edits made by the following vandal accounts:
“dawekiv148” “vecago7283” “febevi3666” “kasiva6740” “tewer84412” “nodofi9184” “tajoced719” “gifokab209” “hefiko2692” “bojicat389” “nomadod999” “focipi8484” “woyeh15025” “bapil95563” “joyboy8” “cinid15546” “palestine forever”
If there any vandal account is missing, please let me know, and I’ll analyze it too.
The reason the results were incomplete was due to the bandwidth limit errors which the program produced and silently ignored…
A modified version found 2073 nodes, 634 ways, and 6 relations deleted by the vandals and not restored.
I can provide the list in any form that would be useful for consumption by the revert tools. It can also include per-element info, such as the version before the first vandalism, the first vandal account to modify/delete it, etc.
Again, I feel that these are not the appropriate time and conditions for me to start using the revert scripts.
Some left over artefacts:
This seems to be missing a number of nodes:
Way: נמל תל אביב (1181998026) | OpenStreetMap
Some nodes still at a wrong location, mostly from a previous revert attempt:
Changeset: 143128522 | OpenStreetMap
Node: 2493584636 | OpenStreetMap
Node: 1998996400 | OpenStreetMap
Node: 5605072299 | OpenStreetMap
Node: 6160021609 | OpenStreetMap
Node: 1998996401 | OpenStreetMap
Node: 2078988732 | OpenStreetMap
Node: 2390930264 | OpenStreetMap
Looking at the first of those on that list, that was deleted by a “real mapper” in this changeset. People can certainly (using the mechanisms described above) undo to the pre-vandalism state, (v1 in the case of that node) but is that really desired here?
That’s your choice, of course, but everyone is a volunteer, including the DWG, the admins, and the people writing all the software. If someone from the local community was to volunteer to help undoing the “vandal” changes it would allow us to move forward quicker.
Link?
Done, by following my own instructions from earlier.
Something else that might be useful is this overpass query. Find somewhere where there should be data but there is not, and this query will find what was there previously. I’ve used it to find some “missing” roads (actually, most seem to be truncated rather than deleted). One thing it found was this building without tags (which hopefully will get restored soon, as I’m doing an “undo” on all of the ways in the most recent vandal changeset. Sometimes already valid data will get rewritten, but some errors will be corrected.
IMO, this is the desired outcome. It is also the only practical path I see to the recovery in the near future of the OSM map in Israel, and for winning again the trust of the veteran mappers.
When comparing the value of the years of mapping vs. the value of the mapping done in the last few week, I’m totally for heritage. Especially as some of the manual mapping was partial, technically incorrect attempt to help recover from the vandalism.
Specifically, the first of those was part pf a valid way before being vandalized by dawekiv148 for the first time. The legitimate user edited while the map revert was incomplete.
Edit:
There is still recovery work at the same junction that manual edit ( tried to fix. In general, I honestly don’t see a way to merge such manual edits with the remaining reverts without extensive manual editing that would leave a a long trace of connectivity issues.
undelete.txt - OSM Israel elements that were deleted by the vandals and not restored yet
Edit:
I’ve gone a step forward and created a JOSM file that will revert them.
See this post
1 Like
OK - so just to be clear - you don’t want me to do anything?
Thank you for asking!
Currently, I think I’ll be able to make that revert. I’ll let you (and everyone else) know if I run into a brick wall…
I found that using JOSM to upload the revert has a side benefit of some consistency checks.
Specifically, this node was manually deleted 18 days ago by a long-contributing user. He probably did that because it had no tags, and it was not connected to any way. However, this node was part of a way deleted by a vandal and not yet reverted.
The point I’m trying to make is that given the partial state of the revert so far, well-meaning editors can make changes that need also to be reverted.
The remaining deleted elements were restored
IMO, the next step of priority is to restore the geometry of way that was damaged by node deletion.
I plan to:
- Use Overpass to find “orphan nodes” - nodes without tags that are not part of a way or a relation
- Use their history find the ways and relations they belonged to
- Restore the pre-vandalism versions of these ways and relations
Dear mappers,
Please DO NOT “clean” the map by removing these orphan nodes
They are a key component for restoring the map
I have completed this stage of the recovery.
306 ways were restored to their original version based on the orphan nodes. Among them were way that had gone through manual fixes. Naturally, that made the revert a bit more complex.
The number of “orphan” nodes went down from 3546 to 2136. 1907 of them are POIs in Petach Tikva that were partially reverted without their original tags. This is the next task in the list.
3 Likes
Not only nodes were stripped off their tags. Here is an example highway that lost its tags, as did many others in that area:
As of now, the Israeli community has identified 2 types of issues that remained after the reverts:
- Ways that lost [some of] their tags, such as Way History: 203762222 | OpenStreetMap
- Ways that lost some nodes, such as Way History: 1058355302 | OpenStreetMap
- Relations that lost some members, such as Relation History: 13284924 | OpenStreetMap
I believe both cases can be identified using Overpass queries with compare block statement:
compare(delta: count_tags() == 0)[orcompare(delta: count_tags())loosing some tags]compare(delta: count_nodes())compare(delta: count_members())
respectively.
I’m preparing scripts for reverting such issues. They will revert the affected elements to their version as of "2023-10-13T19:26:40Z" - before the first known vandal change.
Edit:
A 3rd type of issues was found, and the post was updated accordingly
1 Like
Thanks for effort of everyone involved of cleanup of this!
4 Likes
All vandal effects I’m aware of have been reverted, including
- Node tags and positions
- Way tags and referenced nodes
- Relation tags and their members
Some of the reverts needed manual fix-ups to handle partial reverts and re-mapping
3 Likes
Apparently, there are still some lingering issues, mostly duplication caused by attempts to recover from the vandalism by re-mapping.
I would like to ask that further handling of such issues is done with careful examination of the history to see that the reverts are not undone.
If a semi-automated tool finds a lot of issues, it is likely to be a result of the vandalism, incomplete reverts, and/or re-mapping attempts.
Please let me know if you or your tool finds issues related to the vandalism that you believe have not been handled as needed.
1 Like
Just for info, I’ve just reverted https://www.openstreetmap.org/changeset/144880419 and 20-odd other changesets, so tiles may be a bit confused for a while.
1 Like