The Petah Tikva area here: OpenStreetMap Vandalism Check (left of slider: pre-vandalism state, right of slider: current osm tile cache state) is just a osm tile cache issue?
But looking at other layers (e.g. by osm-fr or TF) it does rather seem to be a data vandalism problem and not a tile cache issue.
I think so. Browse to the area in OSM and turn the data layer on - you should see data. Click on something to see the tags on it.
Edit: Actually - as Firefishy has just mentioned on IRC - there’s quite a lot there without tags. I’ll have a look.
Ah, yes, you are right. The data seems to be ok again, only the re-rendering or tile caches are the issue in that area.
Revert changeset 142939922 seems to be incomplete.
For example, the tags of way 905858370 and others were not restored.
As far s I can see, changeset 142939922 reverted changeset 142936375 by febevi3666, but it didn’t revert the earlier changeset 142936368.
I was unable to get a clear understanding which of the 5 changesets by febevi3666 were reverted correctly and which have not.
Some ways deleted by kasiva6740 were not restored.
For example, way 20035206 way 1119409447 way 1134725773
Each of them was deleted in a different changeset
Yes, you can reapply the tags using the “undo” mechanism described above.
Correct - because there are so many interlinked changesets, you will need to think “object by object” not “changeset by changeset”.
I’d suggest using the “undo” mechanism above for those too.
Some of the ways deleted by kasiva6740 were still not restored. For example:
way 1119409448
way 239160737
way 42464909
way 20035206
Some were restored, but without their tags. For example:
way 1134284446
way 171266521 - a later vandalism was reverted without the tags.
Doubtful. The cache is almost certainly having the same contents as the backend server if you’ve done a reload (control-F5 typically) on osm.org. If it were a tile issue, including on the backend, I’d expect to see lines at metatile boundaries. Those roads terminate normally, not at the edge of a tile.
The ways existed, but had no tags, because a partial revert had happened earlier not a full revert. I reverted the ways affected by that partial revert back to pre-vandalism versions in https://www.openstreetmap.org/changeset/143390925, as noted above.
As noted above you can reapply the tags using the “undo” mechanism described further above. If there are dozens of these we can script it, but if it’s only a few I’d have thought that the community would be able to handle it.
The “force” flag that I talked about earlier says “go back to before all edits by these known vandal users”, and we list all the known vandal users.
You don’t. Partial reverts of some but not all of the vandal accounts is what has caused e.g. ways partially reverted. At this stage the approach needs to be object by object, not account by account.
If you want to restore an element to one of its previous versions, you can also use:
element.pl modify w1234567 --to-version 12
Writes to your latest changeset by default.
Edit: The results below are incomplete. I’m trying to find out why.
There seem to a few dozens of elements that were deleted by the vandals and not restored yet:
Deleted nodes (30 elements):
8301273666, 10790642186, 4031900556, 4031900557, 553058295, 10238272212, 2698056342
4031900567, 4031900568, 4031900570, 4031900571, 11264955995, 11264955997, 10790499103
10790499104, 2698056354, 9077732325, 8487114342, 9077732326, 9077732327, 2698056301
11115674801, 10809083378, 10809083380, 6437900725, 4031900533, 6437900727, 6593146296
6593146297, 6593146299
Deleted ways (89 elements):
1160484608, 265465602, 923124738, 289639438, 289639440, 396031768, 1172669976, 1113376793
1113376794, 1217360156, 816307492, 30779180, 1217360179, 28987956, 1217360180, 1217360181
816307763, 1217360184, 46338105, 1217360186, 365919030, 413477433, 41802045, 1217360192
1133450306, 1133450307, 260326724, 294759749, 1217360196, 1217360199, 1217360200, 374722882
825126746, 43141211, 684776795, 378654560, 393379427, 265465596, 28988261, 30854758, 874214500
143981932, 505904750, 43705456, 143981936, 142816370, 1159050611, 923128692, 43141498, 143981948
26422912, 266451095, 183005603, 631064995, 30879402, 912453293, 1056690094, 183005615, 183005616
1214465716, 1214465717, 1214465718, 926403517, 532023747, 492978628, 1217360328, 1217360329
1106600138, 1106600139, 1217360331, 1106600141, 1217360330, 1217360332, 1217360333, 1217360334
1217360335, 362673883, 1037171934, 1037171935, 368881124, 408943847, 1185335537, 1181227506
1181227507, 1037169395, 898314229, 893168374, 884890364, 973313789
Deleted relations (0 elements):
I feel that these are not the appropriate time and conditions for me to start using the revert scripts.
P.S.,
The lists are for edits made by the following vandal accounts:
“dawekiv148” “vecago7283” “febevi3666” “kasiva6740” “tewer84412” “nodofi9184” “tajoced719” “gifokab209” “hefiko2692” “bojicat389” “nomadod999” “focipi8484” “woyeh15025” “bapil95563” “joyboy8” “cinid15546” “palestine forever”
If there any vandal account is missing, please let me know, and I’ll analyze it too.
The reason the results were incomplete was due to the bandwidth limit errors which the program produced and silently ignored…
A modified version found 2073 nodes, 634 ways, and 6 relations deleted by the vandals and not restored.
I can provide the list in any form that would be useful for consumption by the revert tools. It can also include per-element info, such as the version before the first vandalism, the first vandal account to modify/delete it, etc.
Again, I feel that these are not the appropriate time and conditions for me to start using the revert scripts.
Some left over artefacts:
This seems to be missing a number of nodes:
Way: נמל תל אביב (1181998026) | OpenStreetMap
Some nodes still at a wrong location, mostly from a previous revert attempt:
Changeset: 143128522 | OpenStreetMap
Node: 2493584636 | OpenStreetMap
Node: 1998996400 | OpenStreetMap
Node: 5605072299 | OpenStreetMap
Node: 6160021609 | OpenStreetMap
Node: 1998996401 | OpenStreetMap
Node: 2078988732 | OpenStreetMap
Node: 2390930264 | OpenStreetMap
Looking at the first of those on that list, that was deleted by a “real mapper” in this changeset. People can certainly (using the mechanisms described above) undo to the pre-vandalism state, (v1 in the case of that node) but is that really desired here?
That’s your choice, of course, but everyone is a volunteer, including the DWG, the admins, and the people writing all the software. If someone from the local community was to volunteer to help undoing the “vandal” changes it would allow us to move forward quicker.
Link?
Done, by following my own instructions from earlier.
Something else that might be useful is this overpass query. Find somewhere where there should be data but there is not, and this query will find what was there previously. I’ve used it to find some “missing” roads (actually, most seem to be truncated rather than deleted). One thing it found was this building without tags (which hopefully will get restored soon, as I’m doing an “undo” on all of the ways in the most recent vandal changeset. Sometimes already valid data will get rewritten, but some errors will be corrected.
IMO, this is the desired outcome. It is also the only practical path I see to the recovery in the near future of the OSM map in Israel, and for winning again the trust of the veteran mappers.
When comparing the value of the years of mapping vs. the value of the mapping done in the last few week, I’m totally for heritage. Especially as some of the manual mapping was partial, technically incorrect attempt to help recover from the vandalism.
Specifically, the first of those was part pf a valid way before being vandalized by dawekiv148 for the first time. The legitimate user edited while the map revert was incomplete.
Edit:
There is still recovery work at the same junction that manual edit ( tried to fix. In general, I honestly don’t see a way to merge such manual edits with the remaining reverts without extensive manual editing that would leave a a long trace of connectivity issues.
undelete.txt - OSM Israel elements that were deleted by the vandals and not restored yet
Edit:
I’ve gone a step forward and created a JOSM file that will revert them.
See this post