Sorry for a bot edit escaping its supposed borders (adding website tags)

General talk
1

For start: sorry for accidentally running a bot edit outside Poland that was discussed only with Polish community. Edits were limited to adding/editing website tags. Main problem was that bot was run without required discussion, OSM data should not be damaged.

I noticed (too late) that Mateusz Konieczny - bot account - ATP import | OpenStreetMap performed edits outside Poland/USA, despite that bot edit were not cleared at all outside Poland/USA.

It resulted in adding or improving 2400 website tags - in locations where bot edit was not cleared to run at all. Germany is most affected so I created Sorry for a bot edit escaping its supposed borders (adding website tags in Germany)

Root reason was that location was supposed to be limited to a Poland but required check was not actually performed in the final version of code.

Luckily this defect should be independent from data processing, so website tags should be fine and not damaged.

Edits themselves should be not be breaking data and from spot checking they were fine as far as values of website tags are concerned. But edit was not discussed so it should not have happened. I had nice plan to first run more limited edits, figure and fix problems if any and then propose run in areas that are less bot-happy like Germany to make more likely they will be accepted.
I guess that this plan is thoroughly bungled now.

I am thinking right now what I should do with it, probably I will revert these undiscussed bot edits. But it will take some time, as I need to figure how to do it properly without causing any further issues.

Again: sorry.

15 Likes
2

For me personally, if no degradation of data, no problem. Maybe for someone “bot edit without approval” is bad by definition, but not for mine.

2 Likes
3

The error was caught and reviewed. You’re here letting us know. I think you’ve done an exemplary job in the face of an error that can and will happen when folks are improving the map! I hope it doesn’t deter you from your efforts.

11 Likes
4

I am also considering making bot proposal(s) in affected communities, and if they would receive full support then instead add changeset comments linking approval.

This would result in cleaner history than edit-revert-repeated edit.

2 Likes
5

It took me few months before I had free time to write code necessary for cleanup, but I can now identify impacted areas and classify edits and start revert/approval process.

Proposed imports of website tags for Circle K, based on ATP first-party data was opened for Circle K in USA.

Proposed imports of website tags for NKD, based on ATP first-party data was opened for NKD in Germany.

this is only beginning and some other chains also need to be approved (regular import review, just done in a wrong order) or reverted.

6

Proposed global import of website tags for IKEA, based on ATP first-party data - global proposal for IKEA

Proposed imports of website tags for TerryWhite Chemmart, based on ATP first-party data - TerryWhite Chemmart in Australia