Add shop=gunsmith, for shops that offer repair and modification services to guns but that do not themselves sell guns.
Please discuss this proposal on its wiki talk page.
2 Likes
Nice idea, but wondering if it should possibly be craft=, rather than shop=?
& just looking, it turns out there are actually 15 x craft=gunsmith in use!
9 Likes
Ooh I didn’t know about craft=! That could work too.
This raises the question why car_repair is shop= instead of craft=. And similarly with motorcycle_repair and so on.
& as it’s already “in use” (even if only 15 times), it’s really then only a matter of writing up a wiki page, rather than going through a full proposal! Of course, there’s nothing wrong with still asking for input on what you’re suggesting.
Because they’ve been around as shop= for too long, & used too many times to now change? 
Seriously, it’s just one of the many OSM things that often don’t quite make sense! 
2 Likes
Yes, shop=car_repair was proposed in 2007. Back in the day, we didn’t have very many top-level feature keys. Of the existing keys, shop=* was the closest. This tag was already quite common and well-supported by the time craft=* was approved in 2010.
It probably also has something to do with the fact that shop=car_repair is normally called a “car repair shop” in English. When your car is “in the shop”, that refers to a workshop, not shopping. Silly English. 
5 Likes
You should consider how what you want to tag is distinct from Tag:shop=gun - OpenStreetMap Wiki maybe shop - craft is exactly that, maybe not.
2 Likes
The motivation came from me visiting my local gunsmith and realizing that 1) he’s not mapped and 2) he doesn’t sell guns, so shop=gun doesn’t fit. A similar situation exists with the local audio repair guy (craft=electronics_repair), which is distinct from places that sell electronics (shop=electronics).
3 Likes
A point with this, that you may need to ask him, is does he want to be mapped?
Two gunsmiths we have used do not advertise their actual street address anywhere, including their websites website - you have to ring them to arrange an appointment time, both for general security, & also to make sure that there will be somebody at the front desk to let you in through the locked front door.
Yes of course. I don’t think he has a sign out front, unlike the electronics repair guy.