NSI Tutorial Video: How to create a pull request with no coding?

Help and support
,
1

Hi,

is there a tutorial video on how to create a pull request on Github if I want to add or change a brand in Name Suggestion Index?

Or would anyone be willing to create such a tutorial?

2

There is a good overview of SOTM US 2019 on YouTube: https://www.youtube.com/watch?v=BEe8Hv12J-c

However, in my opinion, the current documentation is likely to be much more helpful: name-suggestion-index/CONTRIBUTING.md at main · osmlab/name-suggestion-index · GitHub

3

What about the ID of a new item, e.g. "id": "aerial-bf4ce0",? Does it need to be entered manually or is it generated automatically?

4

It is generated automatically.

1 Like
5

One more question.

I create commit e.g. new shop=convenience brand and than pull request with this commit.
Then I create a new commit, e.g. amenity=cafe brand but this commit is in pull request with shop=convenience commit.
However, I want this second commit to be in a separate pull request.

Do I have to wait for someone to merge the first pull request or is there another solution?

6

Using git it is normal to make a new branch for each feature that you want to add. This keeps your changes isolated and easily reviewable. Each branch can be its own pull request.

If you already did a bunch of commits on one branch, that’s ok too, but some projects might ask you to break up unrelated work. In the NSI project we try to keep things mostly informal - if you send a Pull Request like “add one cafe and one shop” that would be fine.

GitHub has some decent beginner-focused documentation that can get you started:

2 Likes