Is this mass edit welcomed by community? Mass adding dubious fixme ("'foot=yes' should either be removed (as 'foot=yes' is already an implicit value for a cycleway) OR be upclassified to 'foot=designated'(...)")

Changeset: 154807874 | OpenStreetMap Changeset: 154807892 | OpenStreetMap Changeset: 154807850 | OpenStreetMap Changeset: 154807830 | OpenStreetMap Changeset: 154761183 | OpenStreetMap

I tried contacting mapper (@mikkolukas ) and they failed to respond.

Have they discussed this mass edit or should it be reverted?

Is this fixme actually correct? (foot=yes even if implicit is not wrong or harmful and in my opinion would be an useful clarification)

Is such mass-fixme spamming welcome? (in my opinion: no, it just causes people to ignore fixmes altogether)

I encountered it while going through fixmes and it looks like something that should be reverted given that it looks invalid, edit fails to mention anything required by Automated Edits code of conduct - OpenStreetMap Wiki and mapper ignores changeset comments.
But it is not an area where I edit regularly, so maybe community was consulted and supports it?

I did previously mention this mass edit in another thread about the correct way to tag bicycle paths, but I don’t know of any other discussion about this specific fixme-edit:

However, from what I understand of the discussion linked above, it is not necessarily correct that “foot=yes’ is already an implicit value for a cycleway” in Denmark according to our local road traffic law.

I can’t say with absolute certainty that the mass edit by @mikkolukas has not been discussed anywhere with the community but I personally haven’t noticed it.

1 Like

If the wiki is to be believed, this fixme is just plain wrong. https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions

Emphasis mine:

Note that explicit tagging of access repeating what following tables imply may be still useful. For example bare highway=path may mean either “surveyed and all defaults apply” or “mapped from LIDAR, not surveyed, may be private”. In contrast highway=path + foot=yes + bicycle=yes is more clear what is its meaning. The (sometimes changing) values in the tables below are not a reason to omit explicit tagging on ways in OSM and are also not a reason to remove existing tagging from ways.

I agree that there is no implicite foot=yes for a cycleway.

2 Likes

Any objections to adding a link to this thread on all of those changesets?

(Edit to avoid pointless notifications): I’ve got to give him credit, at least he used fixme instead of actually deleting the tag. Wish I could say the same for the other tags, which he seems to have deleted possibly without discussion. And obviously there’s no excuse for not responding to changeset comments.

About deleting the other tags: [Talk-dk] iD mener der skal vÊre bicycle=designated pÄ alle highway=cycleway

As it stands it seems that mass reverting it would be a good idea. (and can be done by anyone, purely on basis “I am reverting an undiscussed mass edit”)

though waiting a bit would be a good idea before doing this

(also, should be done by someone who know what they are doing - I ma thinking about asking DWG to revert it)

no, I added already on one - will add on remaining

EDIT: added

2 Likes

similar mass edits by this user also happened in the past, see Hvordan kortlÊgger I stier, der bÄde er for cyklister og fodgÊngere? - #10 by Luzandro

I haven’t seen a forum discussion about the automated changesets.

Yes, I agree about reverting.

Not having foot yes on cycleway or path!!! causes many routers not to allow foot there. I.e pedestrian routing is not working!

In Denmark it’s allowed to walk on bicycle ways if there is no alternative, roughly speaking. Foot no sign should ofcause be mapped.

’ Don’t map for the renderer’

That’s not relevant here. “Don’t map for the renderer” (or for the router) means don’t map things incorrectly so that the renderer (or router) gives the result you want. In this case adding access tags isn’t mapping for the router, it’s just mapping accurately.

Or to phrase it differently:

adding (maybe redundant?) foot=yes on cycleway where pedestrians can walk is not mapping incorrect data for the renderer.

See Tagging for the renderer - OpenStreetMap Wiki

EDIT: note, if foot=designated would apply then foot=yes would not be exactly right

1 Like

I absolutely love the example on that page. File:Ankara 3D.png - OpenStreetMap Wiki


Such a perfect example.

Slightly more relevant for this topic though: Tagging for the router - OpenStreetMap Wiki

This changeset has been reverted fully or in part by changesets 165369911, 165369836, 165369884, 165369850, 165369863 where the changeset comment is: revert mass fixme additions by mikkolukas, see Is this mass edit welcomed by community? Mass adding dubious fixme ("'foot=yes' should either be removed (as 'foot=yes' is already an implicit value for a cycleway) OR be upclassified to 'foot=designated'(...)")

1 Like