I am confused why they still appear as author on Note: 5396638 | OpenStreetMap then - usually notes from deleted authors are deleted and their usernames are deleted on their notes.
I had a look at the code. The impression I get is that this happens when the text of a note (but not the note itself) has been marked as hidden.
Technical explanation follows:
Notes are modelled internally in a strange way, where the text of the note is stored in the app as a comment. So the first comment in a note is actually the text of the note, the stored second comment is shown on the website as the first comment, etc. Therefore it’s possible to hide the text of a note as if it were a comment, without hiding the note itself.
is there any way to detect it based on note dumps?
such notes are confusing and pointless (I closed mentioned one) but to detect it I would need to make API call for each existing note which is a terrible idea
I can’t be sure as I don’t know how the dump works, but it sounds like a bug in the dump to me. In the sense that, if it’s hidden on the website, it probably should not show up in the dump either.
I don’t know what the dump looks like either, I only have the example you posted initially, and from there I can’t see how this could be detected. There’s a visible key that I think must be false in the affected comment. The shared JSON doesn’t have this key in your example, so I guess it’s assumed that any comments in the dump are always visible as otherwise they would not appear in the dump. This again points at a bug.
I put on my TODO list investigating how exactly it looks in dump file and making issue based on that
my TODO list is hilariously long and it is not a priority item on entertainment sublist so feel free to make own report if anyone wants… And ideally mention it here