Where Potlatch needs to be improved

Gibuld · 2009-05-12T20:05:27.000Z

Hello Richard,

Hopefully this is the id you need:
http://www.openstreetmap.org/trace/377643/data
The file has been modified in Mapsourse and pspad: tracks were renamed, reorderd, the tag of the last track points removed.
The reordering had the consequense that the tracks were connected in the new order.

Fine, that you tell how to unlock locked ways. Due to my impression they should be unlocked automaticaly as soon I connect them elsewhere.

That I didnÂ´t report error messages has a simple reason: I could not verify what operation actually caused the message.
best regards,
Gibuld

Richard · 2009-05-13T09:13:25.000Z

I think that track must not be public - I can’t see the data. Could you make it public, please?

extremecarver · 2009-05-13T10:26:17.000Z

Regarding “invisible interconnection” → do you know when it will be fixed? I hear that it will be fixed in future since more than 6 month, and routable maps will never work well as long as Potlatch users destroy connections because they can’t notice whether a node is connected or not. If any node connecting different polylines would show up in another color, that’s all what’s needed. Can’t be magic, can it?

Gibuld · 2009-05-13T10:32:50.000Z

Done

Alternatively there existst also this trace, containing only two tracks wich were submitted in two gpx files zipped into one zip.

http://www.openstreetmap.org/user/Gibuld/traces/382243
http://www.openstreetmap.org/trace/382243/data

Gibuld · 2009-05-13T19:12:44.000Z

Richard wrote:

The database might be as quick as Roger Bannister, but if Potlatch sends it a request and it doesn’t respond, there is not much Potlatch can do.

Well, perhaps my feedback gives you arguments in the following direction:
It seems to me, that there has not been installed a correct priority handling on the server.
Edit tasks like Potlatch or JOSM have to be served with highest priority possible other than real time priority. These are the tasks, where data losses imply loss of real work. And these are the tasks where people are waiting online for server response. All other tasks like map display or map generation should have to wait behind those important tasks being served !

Thanks for linking R. Bannister. Was nice to learn about him. You may understand, that running miles is not that popular in Germany, especially since it is not an Olympic discipline.
Have you ever heard of Armin Hary ?
He was the first to run 100 m within 10.0 s. It was often said, if at that time, electronic stopwatches were in use, he would have been the first to run the 100 m under 10 s.

If there is an error please do send the error report to the e-mail address given

What will happen then ? Do I have to stop working until you have finished analyzing ?
The only thing I can see is the error message, but Potlatch still continues running like nothing has happened. And: Potlatch only says, that an error has occurred, but gives no hints what kind of error (as I remember, since I’ve currently stopped working).

“Locked” (red) tracks can be unlocked by clicking the padlock by the way number. It mentions this in the documentation at http://wiki.openstreetmap.org/index.php Â… GPS_tracks . If it’s not clear in the documentation for your language, please do change the wiki page.

You are right, actually in German translation it sounds quite different than in the original. IÂ’ve read several times the according sentence and tried to find a padlock before I had to deal with the locked ways. When I had the problem, I didnÂ’t remember that sentence to be valid just this very moment.
And once again: The way should be unlocked automatically, as soon as it is connected somewhere else. Nobody will try to connect an irrelevant way. And if he does und doesn’t realize the error, he is a fool. A fool who also is able to unlock the way unintentionally.

Richard · 2009-05-17T20:45:58.000Z

extremecarver:

Can’t be magic, can it?

If it’s so easy, why haven’t you fixed it yourself?

But seriously, this is what’s open in another tab on my machine right now:

Richard · 2009-05-17T20:58:06.000Z

Gibuld:

It seems to me, that there has not been installed a correct priority handling on the server.
Edit tasks like Potlatch or JOSM have to be served with highest priority possible other than real time priority.

I’m no expert on the server (if you want a more authoritative answer you should ask on the dev@ mailing list), but - they are already served with a higher priority. See http://trac.openstreetmap.org/browser/sites/rails_port/config/lighttpd.conf - all the ‘write’ operations are served by /dispatch.api, whereas more of the ‘read’ operations are served by /dispatch.bulkapi which has a lower priority.

There are still some problems - in particular, Potlatch’s write operations will sometimes be carried out but not return a success code to the Potlatch client. We have really good guys working on the server and the problems that have arisen with API 0.6 will be ironed out in time. But these are not simple things to fix.

Many of the problems have historically come from memory leaks in Rails and associated libraries (particularly the XML ones), and Rails is a. not our codebase and b. not that easy to debug! If you look through various mailing lists you will see our sysadmins are actively fixing bugs in other people’s code where necessary - e.g. http://www.mail-archive.com/libxml-devel@rubyforge.org/msg01330.html .

Have you ever heard of Armin Hary ?

I hadn’t but I shall go and have a look now.

If there is an error please do send the error report to the e-mail address given

What will happen then ? Do I have to stop working until you have finished analyzing ?

No, but I can’t fix the code if no-one tells me about the error! There appears to be a bug in the Potlatch client at the moment that shows up sometimes when splitting ways; this causes the “node -3 not found in way” -type error. But thus far I can’t reproduce it. If you can find consistent steps to reproduce then that would be the single most helpful thing.

And once again: The way should be unlocked automatically, as soon as it is connected somewhere else. Nobody will try to connect an irrelevant way. And if he does und doesn’t realize the error, he is a fool. A fool who also is able to unlock the way unintentionally.

I’m afraid I don’t agree. If you make ways unlock automatically when they’re connected to another way, then people will start using that method to unlock ways - even if they didn’t want to create a connecting way in the first place. So you’ll get unnecessary ways created.

There is already a good method to unlock a way: click the padlock. That you didn’t realise this appears to be a mistake in the German documentation, not in Potlatch. But then, the next version of Potlatch will have greatly improved documentation built in, and if I can stop answering forum questions for five minutes I might have a chance to finish it this week.

Thanks for the comments as ever.

Richard · 2009-05-17T21:16:41.000Z

Gibuld:

Alternatively there existst also this trace, containing only two tracks wich were submitted in two gpx files zipped into one zip.

Thanks - I’ve used this to find and fix the issue. Will be live in the next version of Potlatch (hopefully some time this week).

extremecarver · 2009-05-18T13:33:06.000Z

Richard:

extremecarver:

Can’t be magic, can it?

If it’s so easy, why haven’t you fixed it yourself?

But seriously, this is what’s open in another tab on my machine right now:
http://www.systemeD.net/osm/connection.png

Okay. that looks great. Will this only apply to ways that are selected or all ways? the square node would be good on all intersections, be they active or not IMHO.

I’m really awaiting it.

Richard · 2009-05-18T14:57:13.000Z

Both the selected way and any that you mouse-over while drawing.

Wynndale · 2009-05-21T07:37:05.000Z

Separate choices of features for open-ended ways and areas would be useful.

Richard · 2009-05-21T13:50:30.000Z

Sorry, what do you mean?

Wynndale · 2009-05-21T17:17:56.000Z

What I mean is that if the points defining a way close in at the end the way is likely to be the outline of a land area or building and unlikely to be a road (except roundabouts). On the other hand a way that doesnÂ’t join back to itself is going to be a road, path, railway line or something similar and couldnÂ’t be the outline of anything. If you distinguish between the two you can offer a decent choice of options for both cases without overwhelming the users.

Gibuld · 2009-05-23T21:52:55.000Z

Surprisingly today I found the new version of Potlatch with the promised modifications.
Thanks a lot, for me Potlatch is now much more useful.
Good: Tracks now correct, junction points now good visible
Not so good: Offline mode not as sure as expected.
Question: Unlocking many ways is tedious. Couldn’t there be defined a shortcut ?

Richard · 2009-05-24T08:17:18.000Z

Gibuld - you can press ‘K’ to lock or unlock a way.

Wynndale - so if I read you right, you’d like a different set of presets for areas (closed ways) to normal ways? I can see the logic but I’m not sure it works for all users. For example, I tend to add tags when I start drawing a way, not when I’ve finished. I wouldn’t be able to do that if Potlatch only presented the “open way” tags to begin with.

Wynndale · 2009-05-30T15:33:07.000Z

If you run Potlatch with separate save and you then switch your browser to another tab your edits are lost without warning. I have just lost 45 minutes of work that way.

Richard · 2009-06-01T12:18:47.000Z

What browser/UI? I’ve never experienced that.

You should be saving every five minutes anyway, not every 45!

Wynndale · 2009-06-02T17:32:43.000Z

I was using IE7 (the only Flash-enabled browser where I was working). I was using the Â‘Edit with saveÂ’ mode and I hit the History tab button (not the browser tab). When I went back to Â‘EditÂ’ Potlatch restarted and downloaded the area as it was before I started editing.

EdLoach · 2009-06-03T08:27:53.000Z

I think Richard will confirm, but I think this is a known issue with Internet Explorer, as I had this problem in December and Richard posted the following:

http://lists.openstreetmap.org/pipermail/talk/2008-December/032364.html

EdLoach · 2009-06-03T08:32:36.000Z

Having said that, I think there have been code changes since to add JS support using ExternalInterface (spotted just in Potlatch.as and World.as) so perhaps it should work. I’ll try and lose some changes here…

Edit:
I can’t get any warning about unsaved changes when switching between Edit and View either in live or offline edit mode using IE8 in both normal and compatibility mode, so I suspect the ExternalInterface amendments aren’t working as desired.

Edit again:
http://trac.openstreetmap.org/browser/sites/rails_port/app/views/site/edit.rhtml?rev=14716

72 window.onbeforeunload=function() {
73 if (!changesaved && !winie) {
74 return “You have unsaved changes. (To save in Potlatch, you should deselect the current way or point.)”;
75 }
76 }

It looks like line 73 deliberately doesn’t give the warning to IE users (and this line predates the addition of the ExternalInterface changes, so may just need tweaking.

Ed