Shop=trade trade=yes and some other useless =yes tags

General talk Tagging general discussion
1

There was a longstanding bug in iD and iD presets where

  1. mapper would create or select shop=trade
  2. mapper would open dropdown for “Type” that allows adding trade= tag
  3. mapper would select none of them and exit dropdown
  4. iD would add trade=yes

At the same time some trade=yes could be added manually, some were added to other shop values or not with iD so they cannot be result of this bug. So just mass-deleting all trade=yes is not a good solution.

But maybe trade=yes should be mass deleted from shop=trade as adding nothing and mostly result of iD bug? Or maybe it would be preferable to contact mappers in changeset where they added them and ask them to come to this thread (would require extra coding to find affected edits and would require spamming those users). Or maybe it would be preferable to do nothing?

Thanks to @maro21 for reporting the bug in Clandestinely adding trade=yes · Issue #11618 · openstreetmap/iD · GitHub

Thanks to @tyr_asd for pointing out the real source of the bug and that my initial proposed fix will break other things.

I fixed it in Fix trade=yes appearing when user tries to cancel editing by matkoniecz · Pull Request #2362 · openstreetmap/id-tagging-schema · GitHub (fix is not released yet)

I also created Tag:trade=yes - OpenStreetMap Wiki and obviously this thread.

After looking is it unique or more opular, I fixed more cases in typeCombo -> combo, to prevent useless =yes values by matkoniecz · Pull Request #2369 · openstreetmap/id-tagging-schema · GitHub (substation=yes, tomb=yes on historic=tomb, wholesale=yes on shop=wholesale)

And more will be fixed by typeCombo -> combo, to prevent useless =yes values (more cases) by matkoniecz · Pull Request #2410 · openstreetmap/id-tagging-schema · GitHub

for example if on highway=tertiary user added traffic_calming= field but left it without selecting any option, no tag should be added

currently traffic_calming=yes is silently added in such case

2 Likes
2

Created this thread primarily to make people aware of it and be less confused if =yes tags appeared seemingly from nowhere and user adding them does not remember adding them.

And discuss potential cleanup. But note: going on mass-purge of =yes values without investigation should not be done, some were added not as result of this bug.

I am also wondering whether pages similar to Tag:trade=yes - OpenStreetMap Wiki would be useful to create for other affected values.

1 Like
3

Go ahead. For a shop=trade an additional trade=yes is worthless redundant tagging. Only if trade=yes is added to any other kind of shop, factory or works it makes sense.

5 Likes