The case of terraced houses being misaligned and offset by an entire building still worries me. Postcodes are less of a worry, but if we are putting `ref:GB:uprn`on each building, those could all be off-by-one.
I don’t know what the answer is, beyond a visual sanity-check in JOSM that the buildings aren’t misaligned.
That’s precisely what I’ll be doing, using the OSMUK LR Polygons overlay as a visual check before uploading. If there’s a terrace which is misaligned by one building, I will either (1) exclude it from the upload, or (2) abort the upload, realign the terrace, re-run my script and upload. (I’ll add this to the wiki page).
For terraces in much of Greater London, I can also use the “NLS - OS 1:1,250/1:2,500 National Grid Maps, 1947-63” layer to confirm the alignment of terraces.
House buildings are mapped as buildings, but it is not the default to add address data to the building.
Address data in the UK is commonly added to either a node within a building, or directly to the building. Adding the address data to the building is more common, but I’d suggest this is due to the way tagging is led through Editors.
We don’t have a correct or default way of adding address data in the UK, but I’m concerned this import will effectively impose address data to buildings
I originally added address data to buildings, but changed to follow local practice and now always add to a node within the building. Primarily because the data we use is from a node, and I came across examples where it was wrong to add the address data to a building.
The data proposed to be added is very useful, and I need to think of a solution, rather than just dump problems into this thread.
Some time ago, I considered writing a straight import proposal that would add UPRNs without the manual checking, by only adding those where everything matched exactly within an area. The presence of UPRNs for various types of things (which can’t be readily identified from the available open data), and the number of objects that they could match to led me to abandon that idea.
I have been adding UPRNs, aided by some scripting in JOSM, and can confirm that the checking is definitely needed. It is also quite straightforward to check visually - I use a combination of a UPRN overlay and a custom style to see where things have been missed, or are misaligned.
The checking that Robert is proposing as part of this would allay any worries I would have about this.
There certainly are buildings which shouldn’t have addresses, blocks of flats with separate entrances being the example which springs most readily to mind. In the parts of London with which I’m most familiar, addresses for houses may start off as interpolation nodes, but usually end up as tags on the buildings. There are also areas where every address is a node within the building polygon, which this import won’t touch.
At present, at least 30% of the 15 million+ buildings in Great Britain have addr:* tags (taginfo).
I’ve always added address to buildings where there is only one address associated with the building. I suppose it would be possible to check whether this is the prevalent way of doing things in the UK, but my impression is that it is. It’s certainly prevalent round my manor.