I have a website to detect and offer fixes for phone numbers in OSM data. Türkiye was added by @hakan in December and since then quite a few of the issues have been fixed. However, there are currently 7693 values detected as invalid, almost 16% of all phone values tagged. Most of these are very easy to fix as they are simply a case of no country code being recorded or someone putting part of the number in brackets.
Take a look at the suggested fixes and let me know what you think.
I have an ongoing bot edit for simple cases and I would like to propose enabling that in Türkiye.
As of today, out of the 7094 suggested fixes, 6896 would be made by the bot. I can provide a list of the exact changes if that is desired. The fixes not made are cases like where there are multiple phone numbers or there is text in the tag value.
Note: I am happy to use the translate button for your replies.
I see that you change numbers with the form of 444 abcd to +90 444 abcd. I am almost sure that these numbers are not callable when prefixed with the country code. Therefore they are only callable within Turkey. I think that change should not be made.
I can’t find a lot of information on such numbers, after a quick search (in English). However, Wikipedia says (without listing a source for this) that they can be dialled from other countries, with a country code. Additionally, Akbank claim that they can be reached via +90 444… from abroad.
If you can find any more information on this, please let me know.
Their situation is same as mine. But there is no solution provided in that topic: Apparently the author “fixed” their problem by using a phone in Turkey…
Thank you for checking that, in which case I will leave such numbers in without +90 and also ensure that if there are any numbers like that with +90 that the suggestion is to remove the +90.
I don’t see that spacing matters at the end like that, +90 123 456 78 90 doesn’t need changing to +90 123 456 7890 or the other way round, and that’s not what the edit is about at all.
I see, thank you. At some point I decided that if we were doing one edit to an element then we may as well format the other numbers while we’re there, on the basis that something like+901234567890 is fairly unreadable and unhelpful for mappers.
Note that the specific edit you point out there would not be made by the bot since it involves a duplicate number. However, in some other case it could happen.
I will therefore remove that reformatting of other numbers so that it only touches actually invalid values.
Correction, having checked over the code, this reformatting only happens when there is a duplicate number, not for any other sort of edit. It’s a little tricky to unpick and so I am tempted to leave it as it is. As I said, these edits would not be made by the bot and people have options for if and how they edit a suggestion shown on the website.
The bot edit commenced today, and will continue to run and clean up new issues as they appear.
Everything left on the website are issues that the bot will not fix. The suggested fixes left are largely multiple numbers in a tag or some cases of duplicate numbers. Most of these edits are likely to be safe, but be sure to report of any issues that you notice.
There are now 802 invalid numbers, of which 199 have fixes suggested. The truly invalid ones are the interesting ones in my opinion, but they do require a bit more work to fix.
