Proposed automated edit of phone numbers in Poland

Communities Polska (Poland)
,
1

I have created a website to validate and fix phone numbers in OSM data, including Poland.

image
image1038Ă—440 49.9 KB

(A Polish translation would be welcome for the site).

Many fixes can be made directly from the website and as a lot of phone values have been fixed, but as you can see, new ones keep getting added.

image
image1038Ă—441 84.7 KB

I have a bot edit running in a number of other countries to automatically fix the simple cases. I would like to propose enabling that in Poland as well.

Please take a look, see what you think of the suggested fixes, make some edits and let me know your thoughts.

(I am happy to use the translate button for your replies)

1 Like
2

is there a list with proposed fixes showing what exactly would be changed by bot into what?

hard to judge bot edit without that

all of “suggested fix” at OSM Phone Number Validation Report - Polska ?

3

If the bot had run today, it would have made 2226 edits, out of 2390 suggested fixes (and total of 3669 detected invalid objects). The excluded ones are things like elements with multiple phone numbers, duplicate phone numbers and any text in the phone tag value.

A full list of the edits that would have been made today is here:

I may be able to transform this to a different format, if that would be more helpful.

(I see that there a number of elements there which appear to show no difference, this is where some unusual character was used, like non-breaking space, which is being replaced with standard space)

1 Like
4

@confusedbuffalo

I reviewed the Mazowieckie file, and it looks good to me.

But I have a concern regarding such a mass edit.
We are not fixing the actual source of the problem.

As you said, many of them have already been fixed, but incorrect values are still increasing.

Until the iD or JOSM validators detect these as incorrect values, they will continue appearing in the OSM db.

Instead, I would by trying to implement rules for things like broken spaces in the JOSM/iD validators (or at least check whether it is possible). I don’t mean enforcing specific formats, because that probably won’t happen.

5

I apologise for not making it clear that this would be an ongoing edit. The bot process runs every day, as part of the website creation. See the bot account for the edits that happen each day in other countries.

Whilst input validation would be good, with the free text nature of the OSM API, it’s not possible to be fully enforced. Every Door checks and formats phone numbers. There’s a plugin for JOSM that does the same.

6

3-digit numbers like 112, 994, 998 should be excluded from the list.

1 Like
7

Of course. I don’t know where you are seeing them, as I am sure that no edits are suggested to such numbers.

8

They’re listed under Invalid Numbers. And while I believe listing them on defibrillator POIs is nonsense, from the perspective of phone number syntax they’re indeed valid.

9

Perhaps I could rephrase the help text there, as I agree that they are invalid to be mapped in the phone tag, hence them being shown as errors.

10

Thank you everyone for the feedback. I have received no concerns about the edits being suggested and so I plan to enable the bot in Poland soon.

11

To confirm, the bot has commenced, leaving 1319 invalid numbers at the moment.

Everything you see on the website will not be fixed by the bot, so take a look and see what can be sorted out manually.