Potlatch Is Generating Circles Several Times Round

TheFive · 2011-06-21T18:19:17.000Z

Hi,

this thread is the summary of the german Thread
http://forum.openstreetmap.org/viewtopic.php?pid=172747#p172747

The current potlach version is generating sometimes circles, that goes several times round.
In Potlatch you have to zoom to very high level to see this, so user are generating the circle and saving it, without any doubt in in correctness.

Here are all examples i have collected, the version before I (TheFive) edited it will be the wrong one.

http://www.openstreetmap.org/browse/way/55724133/history
http://www.openstreetmap.org/browse/way/113696703
http://www.openstreetmap.org/browse/way/110774480 (this one goes 6 times round !)
http://www.openstreetmap.org/browse/way/110756325
http://www.openstreetmap.org/browse/way/4310432
http://www.openstreetmap.org/browse/way/5209478
http://www.openstreetmap.org/browse/way/26408094
http://www.openstreetmap.org/browse/way/24242468

For Potlatch 1 i found in trac:
http://trac.openstreetmap.org/ticket/2489 (18 month old, but sounds similar)

An unmaintained List of bugs helds a similar bug
http://wiki.openstreetmap.org/wiki/Potlatch_2/Archived_obsolete_Bug_list#Make_Circular_going_crazy

I have opened a ticket in trac for Potlatch 2
http://trac.openstreetmap.org/ticket/3786

I have written down a short help of fixing that error
http://wiki.openstreetmap.org/wiki/DE:Fixing_OSMI_self_intersection#Kornkreisel_.28Potlach_gerundete_Mehrfache_Kreise.29
this help contains some screenshots of this error in OSM Inspector and JOSM.

I have asked some Mapper, how they produced that error, but what they told sounds totally normal.
“Draw a quadrate and use the make circular function”.

I have no really idea how to reproduce this error, as i do not use potlatch. My simple try did not work.

In the german forum the question occurred, simply to skip the make circular function from the front page.

This sounds plausible to me,
a) The nice drawed roundabouts are only relevant in high zoom mode.
b) the wrong mapped circles will result in crazy routings i believe, so this error is relevant in many use cases, not only in high zoom mode.
the problem potlatch generating here seems bigger to me than the win in high zoom mode in nice circles.
c) As Potlatch users arn’t able to see this error, they won’t go fixing it by themselves, all users have to wait, that this error is found by a mapper in OSMI.

TheFive · 2011-06-21T19:15:17.000Z

Here is a circle i wont repair, as no routing is effected:

http://www.openstreetmap.org/browse/way/36747683

As this is the 3rd version that is wrong, is it possible to retract the second one with the nodes at that time
and try to reproduce this error ?

TheFive · 2011-06-22T05:52:13.000Z

i have extracted the earlier version of this circle (http://www.openstreetmap.org/browse/way/36747683)



<?xml version='1.0' encoding='UTF-8'?>
<osm version='0.6' generator='JOSM'>
  <node id='-86' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.629729900000015' lon='9.674762300000001' />
  <node id='-85' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62975809999999' lon='9.6747275' />
  <node id='-84' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.6298004' lon='9.6747209' />
  <node id='-83' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.629834299999985' lon='9.674749099999998' />
  <node id='-82' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62985209999998' lon='9.674789600000002' />
  <node id='-81' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62984459999999' lon='9.6748742' />
  <node id='-80' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.629827699999986' lon='9.6748949' />
  <node id='-79' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62976749999999' lon='9.674911800000002' />
  <node id='-78' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62974309999999' lon='9.6748826' />
  <node id='-77' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.62972899999998' lon='9.674847799999998' />
  <node id='-76' action='modify' timestamp='2009-06-21T00:56:04Z' uid='63966' user='MysticFire' visible='true' version='2' lat='49.629725200000024' lon='9.674784899999999' />
  <way id='-75' action='modify' timestamp='2010-02-03T09:23:05Z' uid='225882' user='TGoe' visible='true' version='4'>
    <nd ref='-76' />
    <nd ref='-77' />
    <nd ref='-78' />
    <nd ref='-79' />
    <nd ref='-80' />
    <nd ref='-81' />
    <nd ref='-82' />
    <nd ref='-83' />
    <nd ref='-84' />
    <nd ref='-85' />
    <nd ref='-86' />
    <nd ref='-76' />
    <tag k='note' v='potlatch error' />
    <tag k='test' v='yes' />
  </way>
  <way id='36747683' action='delete' timestamp='2010-02-03T09:23:05Z' uid='225882' user='TGoe' visible='true' version='4' changeset='3781578'>
    <tag k='test' v='yes' />
  </way>
</osm>

i did some modifications and copying not to destroy original data.

You can open this textfile with JOSM upload it to osm and try make circular with potlatch. but this not worked (may be i have moved the circle before, and so it is not reproducable).

Is there a test environment, where everyone can do potlatch tests, without “enriching” original Data ?

TheFive · 2011-06-25T18:30:50.000Z

just to collect further circles:
http://www.openstreetmap.org/browse/way/104504467

Peter_W34 · 2011-09-06T09:06:00.000Z

Hi,
If the roundabout is poorly drawn before using the circle tool, more than one circle will be produced, also after using the tool, if the streets connected to the roundabout are moved around the circle, then the circle tool used a second time, this will produce the bug. I only found that there was a problem in the last week when I started using OSM inspector. The bug can be seen in Potlatch if you no what to look for. The arrows will have multiple heads.

Mark_S · 2011-09-06T15:39:50.000Z

I’ve been running Gary68’s self intersecting ways script on parts of the UK and I’ve seen a number of these cropping up. I’ve fixed about 10 in the last day or two but a quick scan of a couple of the reports for other parts of the UK suggest there are more out there. At least I know where they are coming from now.

Richard · 2011-09-06T16:06:08.000Z

If you can define “poorly drawn” in more detail and add that detail to the trac ticket, we can have a look at it. Unfortunately as yet no-one has provided sufficient steps to reproduce.

Mark_S · 2011-09-06T17:22:41.000Z

After playing around I can consistently reproduce on a couple of roundabouts so I’ve added some information to Trac (first time on Trac so I hope it is right). Broadly it looks to me if you have a roundabout with a node that is incorrectly placed such that the roundabout goes back on itself then multiple circles are created.

Going back on itself seems to depend on latitude / longitude point of view, so moving a node sufficiently out of the initial “circle” means that improving the circle causes potlatch to draw multiple circles.

I’d guess it initially goes wrong because a node is accidentally dragged to the wrong place in the initial roundabout. A user then clicks circle to fix this and get everything back into a circle (seems a logical thing to do to me) which results in something that looks better but is actually worse.

chris66 · 2011-09-06T20:45:01.000Z

Hi,
this are the steps to produce multi-circles in P2:

draw a square
select the square and hit the ‘make circle’ button
shift 2 point like this:

select the line and hit the ‘make circle’ button

result (14 loops):

(Not always 14 loops, but that’s my record )