New "Quality Control" categories in OpenStreetBrowser

skunk · 2022-10-17T20:15:12.143Z

Sorry for the late reply - I thought, I would get a notification about a reply.

I haven’t thought about checking the Wikidata entry, if an image is set - I will add this!

I currently don’t check for Wikipedia at all. I could add a special warning, if a feature has a wikipedia tag but no wikidata tag. Shall I add that?

The check is rather simple. See openstreetbrowser-categories-main/culture-media.yaml at master · plepe/openstreetbrowser-categories-main · GitHub, lines 12 to 29.

Mateusz_Konieczny · 2022-10-17T21:44:12.835Z

skunk:

I currently don’t check for Wikipedia at all. I could add a special warning, if a feature has a wikipedia tag but no wikidata tag. Shall I add that?

I rather thought that presence of wikipedia tag should count like presence of wikidata tag (adding missing one if other is present already is job for bots/validators, not human editors)

BTW, amenity=place_of_worship should also ask for images

skunk · 2022-10-18T15:38:11.407Z

If I count it as wikidata tag, I also should check if it is a person (like for wikidata) - which is not possible right now (from the wikipedia tag value, I have to load the corresponding wikidata object via some SPARQL magic). For now, I will add an extra color for this. I could also, in a next step check if the wikipedia and the wikidata tag point to the same object.

Mateusz_Konieczny:

amenity=place_of_worship should also ask for images

How could I forget! I also added amenity=theatre .

I now also added the check for features with a wikidata object without image.

Btw, if you have more ideas / suggestions / bug reports (in this or other categories, or for new categories), you are welcome to post them to the Github issues: Issues · plepe/openstreetbrowser-categories-main · GitHub

Mateusz_Konieczny · 2022-10-18T15:46:58.870Z

skunk:

from the wikipedia tag value, I have to load the corresponding wikidata object via some SPARQL magic

in my checker I call some API to lookup that info

skunk · 2022-10-18T18:25:06.641Z

Oh, that’s interesting. Could you check, which API you are using?

Mateusz_Konieczny · 2022-10-18T19:10:17.873Z

https://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki&titles=OpenStreetMap&format=json

where I found it:

matkoniecz/wikimedia_connection - wikimedia_connection - Codeberg.org wikimedia_connection/wikimedia_connection.py at master - wikimedia_connection - Codeberg.org

url = "https://www.wikidata.org/w/api.php?action=wbgetentities&sites=" + urllib.parse.quote(language_code) + "wiki&titles=" + urllib.parse.quote(article_name) + "&format=json"

https://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki&titles=OpenStreetMap&format=json

skunk · 2022-10-18T19:12:15.499Z

Thanks! That’s very helpful, I will integrate it.

ivanbranco · 2022-12-27T22:31:42.865Z

skunk:

Culture - Media/Wikidata - In my opinion, each cultural map feature (artwork, memorial, tourist attraction, …) should have an image and/or a wikimedia_commons category (red=missing, light blue=set). Often, there even exists a Wikidata item (dark blue).

I use this layer on my smartphone while travelling to find elements without pictures. Is there a way to filter out elements that already have a picture? Also because often I get confused by the “wikidata+image blue” and the “has wikidata tag, but wikidata object does not have an image blue”.

skunk · 2022-12-29T06:15:14.370Z

ivanbranco:

I use this layer on my smartphone while travelling to find elements without pictures. Is there a way to filter out elements that already have a picture?

Sure, no problem. I created a filter for the different categories (4f78539), I hope that helps.

Filtering for the items which need the result of the wikidata item will need some work in the internals of OpenStreetBrowser though (overpass-layer#25 and openstreetbrowser#168).

ivanbranco:

I get confused by the “wikidata+image blue” and the “has wikidata tag, but wikidata object does not have an image blue”.

Do you think, different colours could help?

Mateusz_Konieczny · 2022-12-29T07:54:21.489Z

skunk:

Do you think, different colours could help?

Yes (I had a similar problem, not sure whether I reported it)

ivanbranco · 2022-12-29T10:40:01.071Z

skunk:

Sure, no problem. I created a filter for the different categories (4f78539), I hope that helps.

Uhm, not really in my case. If I filter “No image, wikimedia_commons or wikidata” I can’t see the elements with a missing image in the “has wikidata tag” (the light blue ones) and viceversa, so I would have to change filter all the time to have a complete picture of the situation.

For “cleaning up” a little bit the map it would be usefult tho to combine both the mentioned filters, so the “image or wikimedia_commons tag but no wikidata” filter would be cut off (or to just exclude this last one?).
I’m thinking more aboout a “checklist filter” rather than a “single choice filter” I guess.

skunk:

Do you think, different colours could help?

Definitely, what confuses me the most are (mainly the two on the right):

skunk · 2023-01-03T17:46:29.825Z

ivanbranco:

For “cleaning up” a little bit the map it would be usefult tho to combine both the mentioned filters, so the “image or wikimedia_commons tag but no wikidata” filter would be cut off (or to just exclude this last one?).

I added a “no image/wikimedia_commons OR wikidata without image” filter. I hope, this is sufficient.

About the colours: do you have a suggestion for a color scheme? You could create a custom category by cloning the category. On the bottom of the code you will find the colour assignments. If you have a scheme with which you are happy with, you can copy&paste the link to your custom category. More about custom categories in my short introduction video: Custom Categories | OpenStreetBrowser - YouTube (cloning categories at 1:24).

ivanbranco · 2023-01-03T18:13:04.427Z

skunk:

I added a “no image/wikimedia_commons OR wikidata without image” filter. I hope, this is sufficient.

This is perfect! Thank you

skunk:

About the colours: do you have a suggestion for a color scheme?

Not really, but with this filter it doesn’t really matter anymore (for me at least) since the two colours don’t appear together.

ivanbranco · 2023-05-23T20:10:17.152Z

Is there a way to export the “no image/wikimedia_commons OR wikidata without image” results so they can be added in OSMand as points?

skunk · 2023-05-24T15:19:34.853Z

Yes, you can export all currently shown map features via the “Export” icon. There’s no assessment though, only the tags of the objects. You could filter the category before downloading.
Screenshot 2023-05-24 at 17-18-00 OpenStreetBrowser

ivanbranco · 2023-05-24T16:23:22.256Z

I tried that already but I am probably doing something wrong, but I don’t know what. I downloaded the three files. If I try to import the .json or the .geojson I get this error “Unexpected token”, if I try to import the .xml file I get this error “I can’t read the GPX data”.

skunk · 2023-05-24T17:26:31.818Z

I see. Apparently OSMAnd can only read GPX files. The OSM XML is the .osm file format developed for OSM data interchange and is not GPX compatible. Sorry, apparently there’s no easy way to use the data for OSMAnd.

Mateusz_Konieczny · 2023-05-25T13:53:10.257Z

skunk:

Sorry, apparently there’s no easy way to use the data for OSMAnd.

Can you open it in JOSM and convert layer to GPX and save it?

ivanbranco · 2023-05-26T09:58:39.007Z

Mateusz_Konieczny:

Can you open it in JOSM and convert layer to GPX and save it?

I tried it and now I can open it with OSMand, the problem is that it exports all “Culture - Media/Wikidata” elements, not only the ones I filtered with “category: no image/wikimedia_commons OR wikidata without image”

Mateusz_Konieczny · 2023-05-26T18:22:07.596Z

But that is problem of initial exported data, right? (and feature request I guess)