Massenedit POI Websites

CjMalone · 2024-10-09T09:05:42.748Z

tux67:

Das war kein langanhaltendes Versprechen: Changeset: 157635419 | OpenStreetMap

I didn’t promise to never help map DE. I said I had no planed edits at the time.

tux67 · 2024-10-09T09:20:55.756Z

Das war auch nicht die Erwartung, ich hab’ den kleinen “Seitenhieb” mal mit einem versehen - mir ging’s um das “wie” nicht das wer oder wann …

OSM_RogerWilco · 2024-10-09T10:51:44.895Z

@CjMalone Leider hast Du noch nicht auf meine Frage geantwortet:

Massenedit POI Websites Deutschland (Germany)

@CjMalone: Kannst Du bitte beschreiben, wie Du das gemacht hast? Wie hast Du die entsprechende Website den einzelnen OSM-Objekten zugeordnet? @CjMalone: Can you please describe how you did this? How did you assign the corresponding website to the individual OSM objects?

CjMalone · 2024-10-09T11:59:15.360Z

I looked for every Netto from the website in OSM. I noticed some didn’t have brand:wikidata, some were mapped as Netto Salling, I did change some of them. I also noticed that some in OSM weren’t on the Netto website, they may be mismapped Netto Salling, or just bad OSM data. I didn’t change these, and I probably wont do a similar edit for Netto Salling since it doesn’t feel like the DE wants it. This edit took hours or my time.

Now anything without a valid url is suspect.

area["ISO3166-1:alpha2"=DE]->.searchArea;
(
  nwr["brand:wikidata"=Q879858][shop]["contact:website"!~"^https:\/\/www\.netto-online\.de\/filialen\/.+\/.+[0-9]+\/?$"][website!~"^https:\/\/www\.netto-online\.de\/filialen\/.+\/.+[0-9]+\/?$"](area.searchArea);
);
out meta;
>;
out meta qt;

OSM_RogerWilco · 2024-10-09T18:48:59.429Z

Mein Frage war, wie Du die Zuordnung gemacht hast?

Z.B. Woher weißt Du, dass die Webseite, die Du hinzugefügt hast zu diesem POI gehört?

OpenStreetMap

Node: ‪MediaMarkt‬ (‪2795213704‬)

OpenStreetMap is a map of the world, created by people like you and free to use under an open license.

My question was, how did you make the matching?

For example, how do you know that the website you added belongs to this POI?

hfs · 2024-10-11T14:13:36.516Z

Wenn man dem Link im website-Tag folgt, kommt man zur Marktseite, wo die Adresse und der ungefähre Ort auf einer Karte angegeben sind. Wenn beide plausibel zum Standort in OSM passen und es keinen anderen Kandidaten in der Nähe gibt, dann wird es wohl der richtige Markt sein.

OSM_RogerWilco · 2024-10-11T14:47:19.616Z

Klar. Man kann auch eine lange Deutschlandreise machen und alle Standorte vor Ort prüfen. Die Frage ist, wie es hier gemacht wurde und ob alle Standorte manuell geprüft wurden oder nicht. Und wenn nicht, wie das Matching gemacht wurde. Bei Massenedits ist es normal und wünschenswert, dass man das Vorgehen dokumentiert und zuvor mit der Community bespricht.

OSM_RogerWilco · 2024-10-30T16:51:42.050Z

Leider immer noch keine Antwort von @CjMalone. Das ist echt traurig und spricht für sich.

CjMalone · 2024-10-30T17:16:45.817Z

OSM_RogerWilco:

Klar. Man kann auch eine lange Deutschlandreise machen und alle Standorte vor Ort prüfen. Die Frage ist, wie es hier gemacht wurde und ob alle Standorte manuell geprüft wurden oder nicht. Und wenn nicht, wie das Matching gemacht wurde. Bei Massenedits ist es normal und wünschenswert, dass man das Vorgehen dokumentiert und zuvor mit der Community bespricht.

These were automated edits. Please revert them.

309_308_307 · 2024-10-30T20:27:22.313Z

Da wurde mal wieder ein Kollege erfolgreich vertrieben. Auch noch ein “UK moderator”, also nicht einfach irgendwer. Sehr traurig das ganze.

OSM_RogerWilco · 2024-10-31T08:37:44.260Z

Man hätte auch einfach die Vorgehensweise erläutern können (wie es auch in den wenigen Regeln, die wir haben, auch vorgesehen ist). Sorry, gerade für einen Moderator ist das ganz schlechter Stil. Kein Verständnis von meiner Seite. Schade.

CjMalone · 2024-11-01T10:49:34.269Z

I have explained my “procedure”, and I have explained my low interest in writing tutorials, evident by me spending hours editing OSM every day and not the wiki. As I thought this was a manual edit there is no requirement for me to document anything further.

However since DE disagrees automated editing coc should be updated to include any changeset with a large bbox, and these edits reverted.

changes made by Bots, which by definition act autonomously from human intervention.

No bot was used.

data imports, including both fully automated imports and ones where a standard editor is used;

Depends on your definition of “import”, but if this is included than this is also an import.

other scripted changes made to the database;

I didn’t script this or program it in any complied language.

use of find-and-replace functionality using a standard editor such as JOSM or finding using services such as Overpass API and changing without reviewing each object individually;

I didn’t use find-and-replace, I do make use of Overpass most days. I do review objects.

manually changing tags without adequate review;

I do make mistakes all the time, I am human. However I’m not aware of anyone finding a mistake in this. Has anyone suggested I haven’t adequately reviewed this? Has anyone suggested these edits made OSM worse?

All I’m guilty of it a large bbox. So this is either guilt by association, or all large bbox edits are automated edits in your eyes.

OpenStreetMap

Changeset: 156223295

OpenStreetMap is a map of the world, created by people like you and free to use under an open license.

OpenStreetMap

Changeset: 156225327

OpenStreetMap is a map of the world, created by people like you and free to use under an open license.

OpenStreetMap

Changeset: 157635419

OpenStreetMap is a map of the world, created by people like you and free to use under an open license.

Please revert these 3 changesets and update the wiki to include large bbox edits in the scope. But don’t worry, I wont edit DE anyway. I got told off for “boosting my edit count” and “making it impossible to revert via lots of small changesets”. I got told off for making making a single changeset with a clear message and very limited scope. (You’ll notice I didn’t delete any duplicates or move anything in this changeset, I do that in separate changesets so it’s easier to review). I got told off for adding POI specific websites because someone just wanted to host name + protocol. No matter what I do, DE isn’t happy. All I’m trying to do is improve OSM.

I spent hours of my life on the changesets alone, and months later you still want more of my time. Revert them and let me be.

Metzor · 2024-11-01T11:26:30.293Z

CjMalone:

All I’m trying to do is improve OSM.

I sincerely acknowledge and appreciate your improvements made to OSM data in Germany. Thank you for your efforts on my behalf!
The procedure you, @CjMalone, described in different posts/comments, seemed valid to me. A pity if the improvements were lost!

Strubbl · 2024-11-01T12:15:21.092Z

OSM_RogerWilco:

Man hätte auch einfach die Vorgehensweise erläutern können (wie es auch in den wenigen Regeln, die wir haben, auch vorgesehen ist).

Link bitte. Welche Regeln meinst du? Ich mache auch öfter solch größere Changesets, wo ich Websites aktualisiere. Das ist alles manuelle Kleinstarbeit und je nach POI steckt da einiges an Recherchezeit drin.

Strubbl · 2024-11-01T12:15:27.267Z

CjMalone:

I got told off for “boosting my edit count” and “making it impossible to revert via lots of small changesets”. I got told off for making making a single changeset with a clear message and very limited scope. (You’ll notice I didn’t delete any duplicates or move anything in this changeset, I do that in separate changesets so it’s easier to review). I got told off for adding POI specific websites because someone just wanted to host name + protocol.

Wow, this is completely crazy. I have no words.

CjMalone:

adding POI specific websites

This is very helpful in future when identifying POIs which are closed, because their custom website is gone then. I also do this where i can and where the website allows this.
Unfortunately many websites nowadays use a CDN, so you cannot easily check the POI specific websites anymore, e.g. Netto and Rewe.

eisa01 · 2024-11-01T15:52:24.476Z

Would just like to point out that “large bbox edits” is fundamentally a frontend / API problem. It can be fixed, such that it’s no longer “annoying”

The NG project has done a try at it:

github.com/openstreetmap-ng/openstreetmap-ng

Support multiple changeset BBoxes and more

openstreetmap-ng:main ← openstreetmap-ng:bboxes

opened 10:08AM - 25 Jul 24 UTC

Zaczero

+1285 -650

- Multiple changeset BBoxes - Simplify cookie authentication (reuse OAuth2)

OpenStreetMap – 25 Jul 24

OpenStreetMap NextGen Development Diary #15

Welcome to the fifteenth OpenStreetMap NextGen development diary.

OSM_RogerWilco · 2024-11-02T08:35:54.086Z

CjMalone:

I have explained my “procedure”

No, unfortunately you didn’t. You didn’t answer my question despite asking several times. By doing so, you deprive us of the opportunity to understand your work properly.

CjMalone:

I do make mistakes all the time, I am human. However I’m not aware of anyone finding a mistake in this. Has anyone suggested I haven’t adequately reviewed this? Has anyone suggested these edits made OSM worse?

I don’t think you understand what I’m actually talking about. It’s not about criticising your work or finding mistakes. It’s about the fact that you should discuss this procedure with the community before making such mass changes. At the latest when there are questions, you should answer them instead of making excuses that you don’t have to do this. Many others go to great lengths and invest a lot of time to do this and respond to questions and comments.

Even if you are going to change tagging of a large number of objects systematically and don’t think that it is an automated edit which falls under this code of conduct, it is still a good idea to discuss your changes in advance.
It’s strange when you write that you simply don’t feel like doing it. Then why don’t you limit yourself to normal OSM mapping?

In any case, I have no interest in deleting your data. Please stop doing that. If you have come to the realisation that it is better to delete the data, then please do it yourself.

Strubbl:

Link bitte. Welche Regeln meinst du?

https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct

Übersetzt mit https://www.deepl.com

Vinzenz_Mai · 2024-11-02T09:54:18.158Z

OSM_RogerWilco:

Automated Edits code of conduct - OpenStreetMap Wiki

Diese treffen hier nicht zu, da jede Änderung manuell mit individueller Überprüfung erfolgte. Somit ist

manually changing tags without adequate review

nicht gegeben, was @CjMalone hier im Thema beschrieben hat.

OSM_RogerWilco · 2024-11-02T10:14:16.078Z

Vinzenz_Mai:

Diese treffen hier nicht zu, da jede Änderung manuell mit individueller Überprüfung erfolgte.

Dann habe ich das übersehen. Wo steht das?

Vinzenz_Mai · 2024-11-02T10:17:17.458Z

Da steht das:

CjMalone:

I do review objects.

und da:

CjMalone:

I spent hours of my life on the changesets alone