Kovoschiz
(Kovoschiz)
4
I would tag motor_vehicle=private for “only employees are allowed to drive motor vehicles on them”. This is consistent with your understanding of “The top right corner of the yard is restricted to employees only, so I’ve set access=private for the service road that passes through that corner.”.
I don’t see where “shop=junk_yard” seems to be “discouraged.”. Problem is, it may not be considered a “shop” (not alone in regards to this). While there’s amenity=scrapyard (this has been voiced out in https://wiki.openstreetmap.org/wiki/Talk:ID/Controversial_Decisions#Why_deprecating_amenity.3Dscrapyard_is_clearly_wrong.3F), more critically I wonder whether it can fall into recycling activities.
The office=yescan be tagged amenity=customers. This could suffice. There are more specific values at single-digit instances https://taginfo.openstreetmap.org/compare/office=scrapyard/office=scrap_yard.
If it is built as an office building, building=office; otherwise building=* + building:use=office.
“according to the OSM wiki, industrial=scrap_yard requires landuse=industrial (which doesn’t belong on a building).” is not entirely correct. It can augment building=industrial, in lieu of a better direct value. The point is it doesn’t represent a single shop/business, only a building or site/facility. It could house multiple shop/businesses, or be used by only one partially.