Doubtful railway=stop bulk edit changeset/170695459

Hi. I came across some dodgy data (which was preventing some railway stations in Spain from being rendered/searchble/etc.).

It was the result of a bulk edit changing railway=halt to railway=stop, which AIUI is wrong. It appears that this mapper didn’t in fact have any information about stopping postions of trains within stations. I’ve been having a discussion with the other mapper in the changeset comments. My feeling is that most of this changeset needs to be reverted.

In some cases other mappers have added an additional railway=halt node, apparently not noticing the railway=stop. So some more subtle query may be needed.

I’d appreciate help/advice with sorting this out. I don’t think reviewing 158 automated edits and fixing them up manually is a workable approach. But I’m also hesitant to get into an overpass-based edit war (!) and anyway I don’t speak overpass well enough to write a sensible recipe.

revert it as undiscussed automated edit violating Automated Edits code of conduct - OpenStreetMap Wiki ?

though sadly manual review may be needed to avoid duplicates - sadly it was not spotted sooner

I think a suitable overpass query could probably find the duplicates. I guess I could try to construct one. Hopefully there’s only a reasonable number, so that I could fix them manually. I think the query I want is “node touched by this changeset, where there is (now) another item with railway={station,halt} nearby”.

Also, you say “revert” but IDK how to do that. It doesn’t seem to be an option in the OSM UI. Could I do that with the in-browser editor? ETA: never mind, found the docs for this on the wiki.

If it’s just one changeset, then it should be possible to do it interactively with JOSM’s reverter plugin - where it finds subsequent edits it’ll prompt you to fix tags and location for each example.

Another option would be the perl revert scripts - that would revert all it can and then generate a list that could be reviewed manually. If anyone wants DWG help with this drop a mail to data@openstreetmap.org with details.

– Andy (from the DWG)

In this case I would probably do it fully manually - and I wrote endless array of custom scripts to help with editing OSM, including revert scripts