Bot proposal: values cleanup for shop

General talk
1

there are some values that are clear typos/duplicates/synonyms of other ones

I want to propose one more bot edit cleaning some of them.

shop = watch → shop = watches
shop = flower → shop = florist
shop = baby_care → shop = baby_goods
shop = cell_phones → shop = mobile_phone
shop = adult → shop = erotic
shop = vacent → shop = vacant
shop = confectionary → shop = confectionery
shop = floor → shop = flooring
shop = spicies → shop = spices
shop = photocopies → shop = copyshop
shop = photocopie → shop = copyshop
shop = jwellery → shop = jewelry
shop = hair_salon → shop = hairdresser
shop = sweets → shop = confectionery
shop = candy → shop = confectionery
shop = white_goods → shop = appliance
shop = appliances → shop = appliance
shop = liquor_store → shop = alcohol
shop = collecting → shop = collector
shop = DIY → shop = doityourself
shop = canabis → shop = cannabis
shop = marihuana → shop = cannabis
shop = newspapers → shop = newsagent
shop = newspaper → shop = newsagent
shop = herbal → shop = herbalist
shop = tile → shop = tiles
shop = delicatessen → shop = deli
shop = carpet_store → shop = carpet
shop = Bag_shop → shop = bag
shop = grocery_store → shop = grocery
shop = shoes_repair → shop = shoe_repair
shop = Roofing_Supply_Store → shop = roofing_supply
shop = Garden Centre → shop = garden_centre
shop = shop=gold_buyer → shop = gold_buyer

Cleaning them up, for clear cases, makes map data more usable, less confusing for newbies and software alike.
At quite low cost of editing objects.
Yes, bot edit WILL cause objects to be edited. Nevertheless, as result map data quality will improve.

Please comment if any of proposed replacements are dubious and should not be replaced with an automated edit.
In such case please, let me know which values are problematic and why.
Note that some are being actively replaced by some editors.

If someone wants to review but needs more than 2 weeks - please write and I can wait for longer.

Please also comment (or +1) if you checked values proposed to be edited and you agree with the edit!

This bot edit would be rerun from time to time, from Changesets by Mateusz Konieczny - bot account | OpenStreetMap bot account.

I have quite decent experience with bot edits, see Mechanical Edits/Mateusz Konieczny - bot account - OpenStreetMap Wiki

If anyone wants I can help them to find affected objects or present listing of edits which added this tags or list people who added this values onto currently tagged osm objects.

Tried to use them as detectors of bogus data, neither were really useful for this purpose.
We have many better ways to find OSM data requiring human review.

If anyone is looking for more cases where human review is needed - I would be glad to list them
(let me know if you are interested in specific area or specific type of issues - maybe only
shop-related? maybe only ones that require survey? maybe only ones fixable remotely?)

But there is no point in manual drudgery here, with values clearly
replaceable by better matches.

Also, I have a massive queue (in thousands and tens of thousands) of automatically detectable issues which are not reported by mainstream validators, require fixes and fix requires review or complete manual cleanup. And where such manual cleanup adds value,
unlike entries from tags listed above.

This edit is documented at Mechanical Edits/Mateusz Konieczny - bot account/fixing malformed shop tags - OpenStreetMap Wiki and is expanding existing one, with tag extension

15 Likes
2

BTW, would it make sense to notify people who used this tags about proposed retagging. Though it would include also people who “added” them because they extracted POI to node. (another case, splitting way into parts - really should not apply here)

4 Likes
3

Maybe reconsider:

shop = board_games → shop = games, board games may be a specialist.

shop = sweets → shop = confectionery
shop = candy → shop = confectionery
shop = sweet → shop = sweets. Looks like a circle. Remove sweets, add sweets.

Also tags with a dozen occurrence in taginfo should be 4-eyes-eviewed.

1 Like
4

I guess you go by which values are more used/documented, because seeing the majority of the conversions being from singular to plural, like shop = watch → shop = watches, but seeing an occasional plural to singular, like shop = cell_phones → shop = mobile_phone, it’s just weird for the consistency.

5

yes, tags in real use are weird mix of plurals and singulars

I see no good reason to deprecate and migrate either shop = watches or shop = mobile_phone, and see no good reason to have plural and singular version of each shop value.

OSM tagging schema has some things going for it, but perfect consistency of naming rules is not one of these things

2 Likes
7

I agree, there are subtle differences in some of the proposed replacements, that it would be a pity to loose them.

An idea could be to use a subtag, e.g.
shop = games together with
games=board_games

or

shop = stationery with
stationery=office_supplies

2 Likes
8

Are all occurrences really about swimming pool stuff? Or maybe also about Pool (cue sports) - Wikipedia?

2 Likes
9

I will drop them, though from Tag:shop=games - OpenStreetMap Wiki and actual use it still seems fine to me

that is the reason for posting the thread and making reviews of such automated edits mandatory

3 Likes
10

Here’s my filtered list of undisputed replacements:

shop = watch → shop = watches
shop = flower → shop = florist
shop = baby_care → shop = baby_goods
shop = cell_phones → shop = mobile_phone
shop = adult → shop = erotic
shop = vacent → shop = vacant
shop = confectionary → shop = confectionery
shop = floor → shop = flooring
shop = spicies → shop = spices
shop = photocopies → shop = copyshop
shop = photocopie → shop = copyshop
shop = jwellery → shop = jewelry
shop = hair_salon → shop = hairdresser
shop = sweets → shop = confectionery
shop = candy → shop = confectionery
shop = appliances → shop = appliance
shop = liquor_store → shop = alcohol
shop = collecting → shop = collector
shop = DIY → shop = doityourself
shop = canabis → shop = cannabis
shop = marihuana → shop = cannabis
shop = newspapers → shop = newsagent
shop = newspaper → shop = newsagent
shop = herbal → shop = herbalist
shop = tile → shop = tiles
shop = delicatessen → shop = deli
shop = carpet_store → shop = carpet
shop = Bag_shop → shop = bag
shop = grocery_store → shop = grocery
shop = shoes_repair → shop = shoe_repair
shop = Roofing_Supply_Store → shop = roofing_supply
shop = Garden Centre → shop = garden_centre
shop = shop=gold_buyer → shop = gold_buyer

3 Likes
11

note that iD at least is pushing direct replacement (maybe it should not, in such case feel free to open an issue at GitHub - openstreetmap/id-tagging-schema: 🆔🏷 The presets and other tagging data used by the iD editor)

(personally I am against replacing any higher use tags with iD “upgrades”)

12

me too, did you already open a ticket?

13

no

(at least 10 characters rule is stupid, can we drop that?)

1 Like
14

and here the list of replacements I would not do:

shop = office_supplies → shop = stationery
shop = board_games → shop = games
shop = pool_supplies → shop = swimming_pool
shop = pet_accessories → shop = pet
shop = frozen_meal → shop = frozen_food
shop = medical_equipment → shop = medical_supply
shop = white_goods → shop = appliance (a bit unsure about this)

15

here’s one Do not propose tags for "automatic" upgrades which have more than x uses · Issue #1845 · openstreetmap/id-tagging-schema · GitHub
add to it if you can

16

status:

pool_supplies and board_games returns to “ask mappers using these tags what they think about migration”

sweet will be proposed on next round with two-stage replacement

stationery in this case I agree with outcome of undiscussed bot edit via iD presets (but not with process itself) and I see no point with subtags here, so I will do nothing for now with it

why? what, even purely theoretical, shop would sell to make this invalid? (kept for now)

this one definitely went through “keep asking local mappers is it valid change” and there was general agreement (kept for now)

with staggering remaining 5 uses worldwide I guess I will ask people who used this tag instead (removed from list)

17

There are different reasons why these replacements are not ok, what is in common is that we would loose information:

frozen meal is a subset of frozen food. Frozen food can be anything eatable in a frozen state, e.g. raw vegetables, meat, fish etc. which may require cooking. On the other hand, frozen meals are already cooked / prepared meals which you only have to warm up.

For the medical tags, these are different categories of items (although there can be shops which sell both, no question): medical equipment is durable, reusable and generally more expensive (comprising devices and machines), while medical supplies are used once (consumables), disposable or short term use.

For “pet_accessories” you can know they do not sell pets but just accessories, while for shop=pet it is not known (likely they sell some kind of pets at least (fish, mice, etc.))

2 Likes
18

this does not really make sense to me with shop = frozen_food and shop = medical_supply being so strongly established in comparison to those and minuscule difference.

But it will be also here faster to just handle it manually and the same for future occurrences rather than argue here.

But difference is so tiny that I would not even bother with subtags.

19

I wonder if that one isn’t too risky, because I can imagine a baby care facility getting tagged like that

2 Likes
20

I do not understand your answer, if these are different things it doesn’t matter whether one is much more established than the other.

I do not follow you either, IMHO the difference between raw food which has to be prepared and cooked meals that are ready to eat, is not “tiny”, nor is the difference between devices and consumables.

1 Like
21

Suggestions:

  • snacks →snack
  • snack_shop →snack