Today I ran the script again and this time multipolygon buildings were included. Didn’t notice any issues with that. Also glad to see that so many new buildings where added during this short period from first import.
Done.
This was actually two step process - deleting redundant addr nodes and removing the addr tags from building nodes.
Not sure address nodes with a different address than the building should have been removed. Here we clearly see that one of the sides of the house on the right had a “Terase” sign.
This node was created to resolve the note which isn’t too old too
In ADS it was changed back in 2014
https://xgis.maaamet.ee/adsavalik/ads?ads_oid=EE00650970
I do not know if the address plate still says Terase, but it definitely did 6 years after the change in ADS.
If care about truth on the ground practice, the node should stay.
https://wiki.openstreetmap.org/wiki/Good_practice#Map_what’s_on_the_ground
Since “Terase 1” sign exists, I restored this address node. This removal of addr nodes was a one time process and I’m not planning to do it again. Automatic script won’t touch nodes, so address nodes can be used in such situations.
Main reason for removing these nodes was to avoid confusion, since both address nodes and addr tags from buildings are usually both rendered.
Hopefully there aren’t too many cases when on the ground address signs differ from ADS.
Were there many nodes with a different address than the building? I’m just thinking that maybe some useful information was deleted and this was just an example.
I would say that most of them matched with the address in a building. Of course there were other examples in Tallinn when it was used for secondary address. If you feel it is important to keep it, even when ADS only has a single address, then the whole changeset can be reverted. I’m fine with that. The biggest number of redundant addr nodes where actually in Viljandi.
IMO, it would be better to filter out addresses where the address differs from the building and not touch them, maybe add a note tag.
https://xgis.maaamet.ee/adsavalik/EE02105714
Here’s another address which can be visible after it was removed from ADS
What I find strange is I don’t remember mapping outdated addresses and I didn’t do a survey either. Why did I add it then? Maybe there is some kind of grace period in Maa-amet’s xgis?
Here is the underlaying data:
node Node modified addr:street addr:housenumber addr:city way building:street building:housenumber building:city
6990909150 2019-11-19T20:49:23Z Holmi kallas 16a Haapsalu 1058207760 Holmi kallas 16a Haapsalu
7177745781 2020-02-01T18:56:48Z Nabe tee 5 Lohusalu küla 1159155410 Nabe tee 5 Lohusalu küla
2428984160 2013-08-23T09:31:51Z Õunapuu pst 126 Maardu 26920570 Huulheina tee 23 Maardu
2428984162 2013-08-23T09:31:51Z Kirsipuu pst 47 Maardu 210035278 Kirsipuu pst 47 Maardu
2428977509 2013-08-23T09:19:11Z Lupiini tee 8 Maardu 26919063 Ploomipuu pst 87 Maardu
7012220802 2019-11-26T19:18:08Z Nelgi 11 Paralepa alevik 1058207751 Nelgi 11 Paralepa alevik
2423992668 2013-08-19T11:22:19Z Võidu 26 Rakvere 40700393 Tallinna 29 Rakvere
5488607385 2018-03-19T11:42:29Z Vanapagana 23 Räni alevik 1094121662 Vanapagana 23 Räni alevik
9316213760 2021-12-06T19:31:06Z Tööstuse 21 Tallinn 26885388 Graniidi 8 Tallinn
2420763188 2013-08-16T13:08:15Z Hariduse 13 Tallinn 26888934 Hariduse 13 Tallinn
1333805267 2011-06-21T18:16:21Z Leevikese 7 26893110 Hauka 13 Tallinn
791779526 2010-06-26T20:55:09Z Voorimehe 2 26889757 Kinga 1 Tallinn
5838603301 2021-08-15T00:31:50Z Vana-Kalamaja 2 Tallinn 199533879 Kopli 2c Tallinn
1322536150 2011-06-12T19:24:52Z Rähni 2 26890268 Kotka 30 Tallinn
1322544594 2011-06-12T19:27:39Z Pardi 2 26891128 Kotka 42 Tallinn
2443104025 2013-09-02T15:18:36Z Urva 23 Tallinn 26871509 Künnapuu 86 Tallinn
2385194051 2013-08-03T14:54:02Z A. H. Tammsaare tee 124 Tallinn 26850189 Laki 25 Tallinn
2455809721 2013-09-12T16:32:24Z Laki 6c Tallinn 830725045 Laki 6 Tallinn
1333805271 2011-06-21T18:16:21Z Vindi 12 26893059 Leevikese 11 Tallinn
1333809890 2011-06-21T18:24:45Z Leevikese 6 26893041 Leevikese 8 Tallinn
1296793569 2011-05-22T22:34:04Z Soone 2 26856116 Lossi 16 Tallinn
8848355034 2021-06-19T13:48:11Z Lubja 9 Tallinn 26896722 Lubja 9/2 Tallinn
6900143962 2019-10-20T12:21:04Z Luite 23c Tallinn 792227949 Luite 23c Tallinn
1404352040 2011-08-19T08:14:52Z Endla 42 Tallinn 26898117 Madara 30 Tallinn
1404626761 2011-08-19T15:50:55Z Endla 40 Tallinn 26898164 Madara 37 Tallinn
2558334612 2013-11-30T11:57:28Z Mooni 42a Tallinn 26887960 Mooni 42a/1 Tallinn
1289372499 2011-05-17T19:28:22Z Mustamäe tee 22 205146815 Mustamäe tee 22 Tallinn
1605616954 2012-01-25T21:18:54Z Tihase 6 26892567 Nõmme tee 16 Tallinn
1333812874 2011-06-21T18:31:49Z Nõmme tee 3a 739266246 Nõmme tee 1a Tallinn
1312274584 2013-08-20T10:23:58Z Pärnu mnt 234 Tallinn 26908368 Pärnu mnt 238 Tallinn
2416585922 2013-08-12T18:23:28Z Rao 2 Tallinn 213182707 Pärnu mnt 474 Tallinn
9413686517 2022-01-12T20:03:37Z Terase 1 Tallinn 26886681 Raua 18 Tallinn
2491922994 2013-12-01T11:55:04Z Raudtee 52a Tallinn 249353207 Raudtee 52j Tallinn
1322539382 2011-06-12T19:26:20Z Rähni 12 26890857 Rähni 12 Tallinn
1322572248 2022-11-03T13:36:29Z Pardi 7a 26887248 Rähni 12a Tallinn
2443104024 2013-09-02T15:18:36Z Papli 13 Tallinn 236259710 Sarapuu 4/2 Tallinn
5523869670 2018-04-03T00:24:42Z Siidisaba 7B Tallinn 26886273 Siidisaba 7 Tallinn
4958273455 2022-01-06T15:56:00Z Suur-Karja 4 Tallinn 26899172 Suur-Karja 4 Tallinn
2488287651 2013-10-08T16:18:13Z Taludevahe 17 Tallinn 26859302 Taludevahe 17 Tallinn
1481457379 2011-10-26T17:22:28Z Tolli 8 134801481 Tolli 8 Tallinn
1298668578 2011-05-24T18:33:08Z Nõmme tee 95 114709088 Tüve 22a Tallinn
2394268799 2013-07-23T19:05:44Z Hämariku 1 26856383 Vabaduse pst 65 Tallinn
2505094165 2013-10-22T15:59:34Z Vabaduse pst 26911953 Vabaduse pst 7 Tallinn
2450459641 2013-09-08T12:23:06Z Salme 9 Tallinn 26903945 Vabriku 41 Tallinn
2450357234 2013-09-08T10:14:18Z Vabriku 8 Tallinn 203117336 Vabriku 8 Tallinn
2450357230 2013-09-08T10:14:18Z Linda 2 Tallinn 203117338 Vabriku 8a Tallinn
2416801045 2013-08-12T20:21:53Z Mooni 49a Tallinn 26895942 Vuti 4 Tallinn
2425683675 2013-08-20T16:06:25Z Mahla 16a Tallinn 26911314 Värava 13 Tallinn
1322527569 2011-06-12T19:20:33Z Pardi 20 26890738 Västriku 10 Tallinn
1322522635 2011-06-12T19:16:52Z Tedre 13 26894243 Västriku 2 Tallinn
2406084603 2013-08-03T15:40:56Z Õie 7 Tallinn 232239341 Õie 7 Tallinn
3841477663 2016-07-21T19:46:18Z Emajõe 1a 30226766 Emajõe 1a Tartu
1191331141 2016-07-21T19:46:18Z Lai 20 Tartu 30234176 Jaani 20 Tartu
4007656680 2016-02-15T15:26:14Z Gildi 9 30221945 Kompanii 8 Tartu
1191346300 2019-04-26T14:29:16Z Turu 21 Tartu 30241341 Turu 21 Tartu
2652728128 2017-03-09T11:34:27Z Tehnika 10/1 Viiratsi alevik 249498459 Tehnika 10 Viiratsi alevik
7846027448 2023-01-17T17:28:38Z Järveotsa puiestee 3 Viljandi 1132938052 Järveotsa pst 3 Viljandi
7846027447 2023-01-17T17:28:38Z Järveotsa puiestee 5 Viljandi 1132938054 Järveotsa pst 5 Viljandi
6812776348 2019-09-20T17:52:37Z Pikk 17 Viljandi 28065693 Lossi 3 Viljandi
6814131138 2019-09-21T14:29:49Z Pikk 23 Viljandi 27950335 Lutsu 8 Viljandi
6814131137 2019-09-21T14:29:49Z Lutsu 7 Viljandi 27950326 Pikk 25 Viljandi
7846027479 2022-01-13T18:03:04Z Tuisu 10 Viljandi 1020917284 Tuisu 10 Viljandi
7846027438 2023-01-17T18:01:09Z Tuisu 11 Viljandi 1020917280 Tuisu 11 Viljandi
7846027446 2023-01-17T17:28:38Z Tuisu 12 Viljandi 1132938063 Tuisu 12 Viljandi
7846027437 2022-01-13T18:03:04Z Tuisu 14 Viljandi 1020917283 Tuisu 14 Viljandi
7846027471 2023-01-17T17:28:38Z Tuisu 18 Viljandi 1132938061 Tuisu 18 Viljandi
7846027450 2023-01-17T17:28:38Z Tuisu 3 Viljandi 1132938055 Tuisu 3 Viljandi
7846027445 2023-01-17T18:01:09Z Tuisu 4 Viljandi 1132946831 Tuisu 4 Viljandi
7846027482 2020-08-26T10:03:23Z Tuisu 6 Viljandi 1132946830 Tuisu 6 Viljandi
7846027451 2023-01-17T18:01:09Z Tuisu 8 Viljandi 1132946829 Tuisu 8 Viljandi
7846027467 2023-01-17T18:01:09Z Vaikuse 10 Viljandi 1132946834 Vaikuse 10 Viljandi
7846027439 2023-01-17T18:01:09Z Vaikuse 11 Viljandi 1020917290 Vaikuse 11 Viljandi
7846027468 2023-01-17T18:01:09Z Vaikuse 12 Viljandi 1132946835 Vaikuse 12 Viljandi
7846027464 2023-01-17T18:01:09Z Vaikuse 14 Viljandi 1132946836 Vaikuse 14 Viljandi
7846027435 2023-01-17T18:01:09Z Vaikuse 16 Viljandi 1132946827 Vaikuse 16 Viljandi
7846027453 2023-01-17T18:01:09Z Vaikuse 17 Viljandi 1132938057 Vaikuse 17 Viljandi
7846027433 2023-01-17T18:01:09Z Vaikuse 19 Viljandi 1132938056 Vaikuse 19 Viljandi
7846027462 2022-01-13T18:03:04Z Vaikuse 24 Viljandi 1020917291 Vaikuse 24 Viljandi
7846027466 2022-01-13T18:03:04Z Vaikuse 26 Viljandi 1020917294 Vaikuse 26 Viljandi
7846027475 2023-01-17T17:28:38Z Vaikuse 28 Viljandi 1132938060 Vaikuse 28 Viljandi
7846027431 2023-01-17T18:01:09Z Vaikuse 30 Viljandi 1020917295 Vaikuse 30 Viljandi
7846027470 2023-01-17T17:28:38Z Vaikuse 4 Viljandi 1132938053 Vaikuse 4 Viljandi
7846027481 2022-01-13T18:03:04Z Vaikuse 6 Viljandi 1132946838 Vaikuse 6 Viljandi
7846027443 2023-01-17T18:01:09Z Vaikuse 8 Viljandi 1132946837 Vaikuse 8 Viljandi
7846027476 2022-01-13T18:03:04Z Vaikuse põik 10 Viljandi 1020917285 Vaikuse põik 10 Viljandi
7846027469 2023-01-17T18:01:09Z Vaikuse põik 4 Viljandi 1132946824 Vaikuse põik 4 Viljandi
7846027477 2022-01-13T18:03:04Z Vaikuse põik 6 Viljandi 1020917289 Vaikuse põik 6 Viljandi
7846027441 2022-01-13T18:03:04Z Vaikuse põik 8 Viljandi 1020917286 Vaikuse põik 8 Viljandi
You can use it any way you want to revert/partially restore/add note etc. I personally don’t care. The number of affected nodes is so small it doesn’t matter to me.
For the past 4 months I have run this ADS script monthly, without any significant issues. Each time I run it, it verifies address data for over 650 000 builings and updates addr tags as needed. So far I’ve updated address for ~105 000 buildings:
Is there a need update the rest of the buildings to indicate that the building does still exist and it has correct address tags?
This would mean updating most EE buildings and setting source:addr to Maa-amet 2024 in the beginning of a next year. To be perfectly honest, I’m not sure if it’s good idea to perform such a large scale change.
