I installed a Viofo A119s V2 dash cam with GPS mount in my car for other reasons and have found it a useful addition to my mapping.

Upsides:
It is always on so even if I am not planning on mapping on a trip I can still go back and review the videos if I notice something during that trip that ought to be mapped.

While it does not pick up everything, it picks up items that I haven’t bothered to map in the past (bus stops, etc.). Driving through a small town I am more likely to notice and map gas stations and other businesses. Using tools like OsmTracker that was not feasible to do while driving.

Downsides:

Getting the GPX tracks from it requires a bit of futzing (I am on a Mac and the best apps for using that data are Windows based).

Field of view is a bit narrow, so I can’t get all the store signs I’d like.

Street signs, etc. can be a bit too low resolution to easily read.

Support for editing maps using video is not as well developed as I’d like. I end up fast forwarding through my video clips looking for things that could be mapped. Then I use the lat/lon display I have enabled on the video to get to that location in JOSM to add the feature. This is slower and more tedious than I’d like. If the road alignment looks reasonably correct based on satellite imagery and previously uploaded tracks I don’t bother extracting the GPX from the video as that is a bit of a hassle for me.

It would be really nice if JOSM could directly import the GPX from the video files and show you image from any location in the track. Apparently there was once a plug-in that attempted that but it seems to be old and unsupported. No doubt a real effort to bring that up to date as a it seems that there is no real standard or documentation for how dash cams record GPS data.